| # Licensed to the Apache Software Foundation (ASF) under one |
| # or more contributor license agreements. See the NOTICE file |
| # distributed with this work for additional information |
| # regarding copyright ownership. The ASF licenses this file |
| # to you under the Apache License, Version 2.0 (the |
| # "License"); you may not use this file except in compliance |
| # with the License. You may obtain a copy of the License at |
| # |
| # http://www.apache.org/licenses/LICENSE-2.0 |
| # |
| # Unless required by applicable law or agreed to in writing, |
| # software distributed under the License is distributed on an |
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY |
| # KIND, either express or implied. See the License for the |
| # specific language governing permissions and limitations |
| # under the License. |
| """ Tests for Multiple IP Ranges feature |
| """ |
| from marvin.cloudstackTestCase import cloudstackTestCase |
| from marvin.cloudstackException import CloudstackAPIException |
| from marvin.lib.utils import cleanup_resources |
| from marvin.lib.base import (PublicIpRange) |
| from marvin.lib.common import (get_domain, |
| get_zone, |
| get_pod) |
| from netaddr import IPAddress, IPNetwork |
| import random |
| from nose.plugins.attrib import attr |
| |
| |
| class TestMultipleIpRanges(cloudstackTestCase): |
| |
| """Test Multiple IP Ranges for guest network |
| """ |
| |
| @classmethod |
| def setUpClass(cls): |
| cls.testClient = super(TestMultipleIpRanges, cls).getClsTestClient() |
| cls.api_client = cls.testClient.getApiClient() |
| |
| cls.services = cls.testClient.getParsedTestDataConfig() |
| # Get Zone, Domain and templates |
| cls.domain = get_domain(cls.api_client) |
| cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests()) |
| cls.pod = get_pod(cls.api_client, cls.zone.id) |
| cls.services["zoneid"] = cls.zone.id |
| cls._cleanup = [] |
| return |
| |
| @classmethod |
| def tearDownClass(cls): |
| try: |
| # Cleanup resources used |
| cleanup_resources(cls.api_client, cls._cleanup) |
| except Exception as e: |
| raise Exception("Warning: Exception during cleanup : %s" % e) |
| return |
| |
| def setUp(self): |
| self.apiclient = self.testClient.getApiClient() |
| self.dbclient = self.testClient.getDbConnection() |
| self.cleanup = [] |
| return |
| |
| def tearDown(self): |
| try: |
| # Clean up, terminate the resources created |
| cleanup_resources(self.apiclient, self.cleanup) |
| except Exception as e: |
| raise Exception("Warning: Exception during cleanup : %s" % e) |
| return |
| |
| def increment_cidr(self): |
| """Takes CIDR as input and will increment by one and returns the new CIDR |
| """ |
| publicIpRange = PublicIpRange.list(self.apiclient) |
| self.startIp = publicIpRange[0].startip |
| self.endIp = publicIpRange[0].endip |
| self.gateway = publicIpRange[0].gateway |
| self.netmask = publicIpRange[0].netmask |
| # Pass ip address and mask length to IPNetwork to findout the CIDR |
| ip = IPNetwork(self.startIp + "/" + self.netmask) |
| # Take random increment factor to avoid adding the same vlan ip range |
| # in each test case |
| networkIncrementFactor = random.randint(1,255) |
| new_cidr = ip.__iadd__(networkIncrementFactor) |
| ip2 = IPNetwork(new_cidr) |
| return ip2 |
| |
| def verify_vlan_range(self, vlan, services): |
| # compare vlan_list response with configured values |
| self.assertEqual( |
| isinstance(vlan, list), |
| True, |
| "Check list response returned a valid list" |
| ) |
| self.assertNotEqual( |
| len(vlan), |
| 0, |
| "check list vlan response" |
| ) |
| self.assertEqual( |
| str(vlan[0].startip), |
| str(services["startip"]), |
| "Start IP in vlan ip range is not matched with\ |
| the configured start ip" |
| ) |
| self.assertEqual( |
| str(vlan[0].endip), |
| str(services["endip"]), |
| "End IP in vlan ip range is not matched with\ |
| the configured end ip" |
| ) |
| self.assertEqual( |
| str(vlan[0].gateway), |
| str(services["gateway"]), |
| "gateway in vlan ip range is not matched with\ |
| the configured gateway" |
| ) |
| self.assertEqual( |
| str(vlan[0].netmask), |
| str(services["netmask"]), |
| "netmask in vlan ip range is not matched with\ |
| the configured netmask" |
| ) |
| return |
| |
| @attr(tags=["sg"]) |
| def test_01_add_ip_same_cidr(self): |
| """Test add guest ip range in the existing cidr |
| """ |
| # call increment_cidr function to get exiting cidr from the setup and |
| # increment it |
| ip2 = self.increment_cidr() |
| test_nw = ip2.network |
| ip = IPAddress(test_nw) |
| # Add IP range(5 IPs) in the new CIDR |
| test_gateway = ip.__add__(1) |
| test_startIp = ip.__add__(3) |
| test_endIp = ip.__add__(10) |
| test_startIp2 = ip.__add__(11) |
| test_endIp2 = ip.__add__(15) |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp |
| self.services["vlan_ip_range"]["endip"] = test_endIp |
| self.services["vlan_ip_range"]["gateway"] = test_gateway |
| self.services["vlan_ip_range"]["netmask"] = self.netmask |
| self.services["vlan_ip_range"]["zoneid"] = self.zone.id |
| self.services["vlan_ip_range"]["podid"] = self.pod.id |
| # create new vlan ip range |
| self.debug("Creating new ip range with new cidr in the same vlan") |
| new_vlan = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp, test_endIp)) |
| self.cleanup.append(new_vlan) |
| new_vlan_res = new_vlan.list(self.apiclient, id=new_vlan.vlan.id) |
| # Compare list output with configured values |
| self.verify_vlan_range(new_vlan_res, self.services["vlan_ip_range"]) |
| # Add few more ips in the same CIDR |
| self.services["vlan_ip_range"]["startip"] = test_startIp2 |
| self.services["vlan_ip_range"]["endip"] = test_endIp2 |
| self.debug("Creating new ip range in the existing CIDR") |
| new_vlan2 = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp2, test_endIp2)) |
| self.cleanup.append(new_vlan2) |
| # list new vlan ip range |
| new_vlan2_res = new_vlan2.list(self.apiclient, id=new_vlan2.vlan.id) |
| # Compare list output with configured values |
| self.verify_vlan_range(new_vlan2_res, self.services["vlan_ip_range"]) |
| return |
| |
| @attr(tags=["sg"]) |
| def test_02_add_ip_diff_cidr(self): |
| """Test add ip range in a new cidr |
| |
| Steps: |
| 1.Get public vlan range (guest cidr) from the setup |
| 2.Add IP range to a new cidr |
| """ |
| # call increment_cidr function to get exiting cidr from the setup and |
| # increment it |
| ip2 = self.increment_cidr() |
| test_nw = ip2.network |
| ip = IPAddress(test_nw) |
| # Add IP range(5 IPs) in the new CIDR |
| test_gateway = ip.__add__(1) |
| test_startIp = ip.__add__(3) |
| test_endIp = ip.__add__(10) |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp |
| self.services["vlan_ip_range"]["endip"] = test_endIp |
| self.services["vlan_ip_range"]["gateway"] = test_gateway |
| self.services["vlan_ip_range"]["netmask"] = self.netmask |
| self.services["vlan_ip_range"]["zoneid"] = self.zone.id |
| self.services["vlan_ip_range"]["podid"] = self.pod.id |
| # create new vlan ip range |
| self.debug("Adding new ip range in different CIDR in same vlan") |
| new_vlan = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp, test_endIp)) |
| self.cleanup.append(new_vlan) |
| new_vlan_res = new_vlan.list(self.apiclient, id=new_vlan.vlan.id) |
| # Compare list output with configured values |
| self.verify_vlan_range(new_vlan_res, self.services["vlan_ip_range"]) |
| return |
| |
| @attr(tags=["sg"]) |
| def test_03_del_ip_range(self): |
| """Test delete ip range |
| |
| Steps: |
| 1.Add ip range in same/new cidr |
| 2.delete the ip range added at step1 |
| 3.Verify the ip range deletion using list APIs |
| """ |
| # call increment_cidr function to get exiting cidr from the setup and |
| # increment it |
| ip2 = self.increment_cidr() |
| test_nw = ip2.network |
| ip = IPAddress(test_nw) |
| # Add IP range(5 IPs) in the new CIDR |
| test_gateway = ip.__add__(1) |
| test_startIp = ip.__add__(3) |
| test_endIp = ip.__add__(10) |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp |
| self.services["vlan_ip_range"]["endip"] = test_endIp |
| self.services["vlan_ip_range"]["gateway"] = test_gateway |
| self.services["vlan_ip_range"]["netmask"] = self.netmask |
| self.services["vlan_ip_range"]["zoneid"] = self.zone.id |
| self.services["vlan_ip_range"]["podid"] = self.pod.id |
| # create new vlan ip range |
| self.debug("Creating new ip range in the new cidr") |
| new_vlan = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp, test_endIp)) |
| new_vlan_res = new_vlan.list(self.apiclient, id=new_vlan.vlan.id) |
| # Compare list output with configured values |
| self.verify_vlan_range(new_vlan_res, self.services["vlan_ip_range"]) |
| # Delete the above IP range |
| self.debug("Deleting new ip range added in new cidr") |
| new_vlan.delete(self.apiclient) |
| # listing vlan ip ranges with the id should through exception , if not |
| # mark the test case as failed |
| try: |
| new_vlan.list(self.apiclient, id=new_vlan.vlan.id) |
| except CloudstackAPIException as cs: |
| self.debug(cs.errorMsg) |
| self.assertTrue( |
| cs.errorMsg.find("entity does not exist") > 0, |
| msg="Failed to delete IP range") |
| return |
| |
| @attr(tags=["sg"]) |
| def test_04_add_noncontiguous_ip_range(self): |
| """Test adding non-contiguous ip range in existing cidr |
| |
| 1.Add ip range in new cidr |
| 1.Add non-contigous ip range in cidr added at step1 |
| 2.Verify the ip range using list APIs |
| """ |
| # call increment_cidr function to get exiting cidr from the setup and |
| # increment it |
| ip2 = self.increment_cidr() |
| test_nw = ip2.network |
| ip = IPAddress(test_nw) |
| # Add IP range(5 IPs) in the new CIDR |
| test_gateway = ip.__add__(1) |
| test_startIp = ip.__add__(50) |
| test_endIp = ip.__add__(60) |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp |
| self.services["vlan_ip_range"]["endip"] = test_endIp |
| self.services["vlan_ip_range"]["gateway"] = test_gateway |
| self.services["vlan_ip_range"]["netmask"] = self.netmask |
| self.services["vlan_ip_range"]["zoneid"] = self.zone.id |
| self.services["vlan_ip_range"]["podid"] = self.pod.id |
| # create new vlan ip range |
| new_vlan = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp, test_endIp)) |
| self.cleanup.append(new_vlan) |
| new_vlan_res = new_vlan.list(self.apiclient, id=new_vlan.vlan.id) |
| # Compare list output with configured values |
| self.verify_vlan_range(new_vlan_res, self.services["vlan_ip_range"]) |
| # Add non-contiguous ip range in exiting cidr |
| test_startIp2 = ip.__add__(10) |
| test_endIp2 = ip.__add__(20) |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp2 |
| self.services["vlan_ip_range"]["endip"] = test_endIp2 |
| # create new vlan ip range |
| self.debug("Adding non contiguous ip range") |
| new_vlan = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp, test_endIp)) |
| self.cleanup.append(new_vlan) |
| new_vlan_res = new_vlan.list(self.apiclient, id=new_vlan.vlan.id) |
| # Compare list output with configured values |
| self.verify_vlan_range(new_vlan_res, self.services["vlan_ip_range"]) |
| return |
| |
| @attr(tags=["sg"]) |
| def test_05_add_overlapped_ip_range(self): |
| """Test adding overlapped ip range in existing cidr |
| |
| 1.Add ip range in new cidr e.g:10.147.40.10-10.147.40.100 |
| 2.Add ip range overlapped with the ip range in |
| step1 e.g.10.147.40.90-150 |
| """ |
| # call increment_cidr function to get exiting cidr from the setup and |
| # increment it |
| ip2 = self.increment_cidr() |
| test_nw = ip2.network |
| ip = IPAddress(test_nw) |
| # Add IP range in the new CIDR |
| test_gateway = ip.__add__(1) |
| test_startIp = ip.__add__(10) |
| test_endIp = ip.__add__(30) |
| test_startIp2 = ip.__add__(20) |
| test_endIp2 = ip.__add__(40) |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp |
| self.services["vlan_ip_range"]["endip"] = test_endIp |
| self.services["vlan_ip_range"]["gateway"] = test_gateway |
| self.services["vlan_ip_range"]["netmask"] = self.netmask |
| self.services["vlan_ip_range"]["zoneid"] = self.zone.id |
| self.services["vlan_ip_range"]["podid"] = self.pod.id |
| # create new vlan ip range |
| self.debug( |
| "Creating new ip range with startip:%s and endip: %s".format( |
| test_startIp, |
| test_endIp)) |
| new_vlan = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp, test_endIp)) |
| self.cleanup.append(new_vlan) |
| new_vlan_res = new_vlan.list(self.apiclient, id=new_vlan.vlan.id) |
| # Compare list output with configured values |
| self.verify_vlan_range(new_vlan_res, self.services["vlan_ip_range"]) |
| # Add overlapped ip range |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp2 |
| self.services["vlan_ip_range"]["endip"] = test_endIp2 |
| # Try to create ip range overlapped with exiting ip range |
| self.debug("Adding overlapped ip range") |
| try: |
| new_vlan2 = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| except CloudstackAPIException as cs: |
| self.debug(cs.errorMsg) |
| self.assertTrue( |
| cs.errorMsg.find("already has IPs that overlap with the new range") > 0, |
| msg="Fail:CS allowed adding overlapped ip\ |
| ranges in guest cidr") |
| return |
| # Test will reach here if there is a bug in overlap ip range checking |
| self.cleanup.append(new_vlan2) |
| self.fail( |
| "CS should not accept overlapped ip ranges in\ |
| guest traffic, but it allowed") |
| return |
| |
| @attr(tags=["sg"]) |
| def test_06_add_ip_range_overlapped_with_two_ranges(self): |
| """Test adding overlapped ip range with two existing cidr |
| |
| 1.Add ip range in new cidr e.g:10.147.40.2-10.147.40.10 |
| 2.Add another ip range in the same cidr |
| e.g:10.147.40.20-10.147.40.30 |
| 3.Add ip range overlapped with both the ip ranges |
| e.g.10.147.40.10-20 |
| """ |
| # call increment_cidr function to get exiting cidr from the setup and |
| # increment it |
| ip2 = self.increment_cidr() |
| test_nw = ip2.network |
| ip = IPAddress(test_nw) |
| # Add IP range in the new CIDR |
| test_gateway = ip.__add__(1) |
| test_startIp = ip.__add__(2) |
| test_endIp = ip.__add__(5) |
| test_startIp2 = ip.__add__(7) |
| test_endIp2 = ip.__add__(10) |
| test_startIp3 = ip.__add__(5) |
| test_endIp3 = ip.__add__(7) |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp |
| self.services["vlan_ip_range"]["endip"] = test_endIp |
| self.services["vlan_ip_range"]["gateway"] = test_gateway |
| self.services["vlan_ip_range"]["netmask"] = self.netmask |
| self.services["vlan_ip_range"]["zoneid"] = self.zone.id |
| self.services["vlan_ip_range"]["podid"] = self.pod.id |
| # create new vlan ip range |
| new_vlan = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp, test_endIp)) |
| self.cleanup.append(new_vlan) |
| new_vlan_res = new_vlan.list(self.apiclient, id=new_vlan.vlan.id) |
| # Compare list output with configured values |
| self.verify_vlan_range(new_vlan_res, self.services["vlan_ip_range"]) |
| # Add 2nd IP range in the same CIDR |
| self.services["vlan_ip_range"]["startip"] = test_startIp2 |
| self.services["vlan_ip_range"]["endip"] = test_endIp2 |
| new_vlan2 = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp2, test_endIp2)) |
| self.cleanup.append(new_vlan2) |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp3 |
| self.services["vlan_ip_range"]["endip"] = test_endIp3 |
| # Try to create ip range overlapped with exiting ip range |
| self.debug("Adding ip range overlapped with two cidrs") |
| try: |
| new_vlan3 = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| except CloudstackAPIException as cs: |
| self.debug(cs.errorMsg) |
| self.assertTrue( |
| cs.errorMsg.find("already has IPs that overlap with the new range") > 0, |
| msg="Fail:CS allowed adding overlapped ip\ |
| ranges in guest cidr") |
| return |
| # Test will reach here if there is a bug in overlap ip range checking |
| self.cleanup.append(new_vlan3) |
| self.fail( |
| "CS should not accept overlapped ip ranges in guest\ |
| traffic, but it allowed") |
| return |
| |
| @attr(tags=["sg"]) |
| def test_07_add_iprange_superset(self): |
| """Test adding ip range superset to existing CIDR |
| |
| 1.Add IP range in new CIDR |
| 2.Try to add ip range superset to CIDR added in step1 |
| """ |
| # call increment_cidr function to get exiting cidr from the setup and |
| # increment it |
| ip2 = self.increment_cidr() |
| test_nw = ip2.network |
| ip = IPAddress(test_nw) |
| # Add IP range in the new CIDR |
| test_gateway = ip.__add__(1) |
| test_startIp = ip.__add__(2) |
| test_endIp = ip.__add__(10) |
| test_startIp2 = ip.__add__(20) |
| test_endIp2 = ip.__add__(30) |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp |
| self.services["vlan_ip_range"]["endip"] = test_endIp |
| self.services["vlan_ip_range"]["gateway"] = test_gateway |
| self.services["vlan_ip_range"]["netmask"] = self.netmask |
| self.services["vlan_ip_range"]["zoneid"] = self.zone.id |
| self.services["vlan_ip_range"]["podid"] = self.pod.id |
| # create new vlan ip range |
| new_vlan = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp, test_endIp)) |
| self.cleanup.append(new_vlan) |
| new_vlan_res = new_vlan.list(self.apiclient, id=new_vlan.vlan.id) |
| # Compare list output with configured values |
| self.verify_vlan_range(new_vlan_res, self.services["vlan_ip_range"]) |
| # Add ip range superset to the existing CIDR |
| # Following code finds the netmask superset to existing CIDR |
| cidr = ip2.cidr |
| mask_len = 2 ** (32 - cidr.prefixlen) |
| netmask = IPAddress(self.netmask) |
| superset = netmask.__isub__(mask_len) |
| # Add this superset netmask to services |
| self.services["vlan_ip_range"]["netmask"] = superset |
| self.services["vlan_ip_range"]["startip"] = test_startIp2 |
| self.services["vlan_ip_range"]["endip"] = test_endIp2 |
| self.debug("Adding IP range super set to existing CIDR") |
| try: |
| new_vlan2 = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| except CloudstackAPIException as cs: |
| self.debug(cs.errorMsg) |
| self.assertTrue( |
| cs.errorMsg.find("superset") > 0, |
| msg="Fail: CS allowed adding ip range\ |
| superset to existing CIDR") |
| return |
| # Test will reach here if there is a bug in allowing superset ip range |
| self.cleanup.append(new_vlan2) |
| self.fail( |
| "CS should not allow adding ip range superset to existing CIDR") |
| return |
| |
| @attr(tags=["sg"]) |
| def test_08_add_iprange_subset(self): |
| """Test adding ip range subset to existing CIDR |
| |
| 1.Add IP range in new CIDR |
| 2.Try to add ip range subset to CIDR added in step1 |
| """ |
| # call increment_cidr function to get exiting cidr from the setup and |
| # increment it |
| ip2 = self.increment_cidr() |
| test_nw = ip2.network |
| ip = IPAddress(test_nw) |
| # Add IP range in the new CIDR |
| test_gateway = ip.__add__(1) |
| test_startIp = ip.__add__(2) |
| test_endIp = ip.__add__(10) |
| test_startIp2 = ip.__add__(20) |
| test_endIp2 = ip.__add__(30) |
| # Populating services with new IP range |
| self.services["vlan_ip_range"]["startip"] = test_startIp |
| self.services["vlan_ip_range"]["endip"] = test_endIp |
| self.services["vlan_ip_range"]["gateway"] = test_gateway |
| self.services["vlan_ip_range"]["netmask"] = self.netmask |
| self.services["vlan_ip_range"]["zoneid"] = self.zone.id |
| self.services["vlan_ip_range"]["podid"] = self.pod.id |
| # create new vlan ip range |
| new_vlan = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| self.debug( |
| "Created new vlan range with startip:%s and endip:%s" % |
| (test_startIp, test_endIp)) |
| self.cleanup.append(new_vlan) |
| new_vlan_res = new_vlan.list(self.apiclient, id=new_vlan.vlan.id) |
| # Compare list output with configured values |
| self.verify_vlan_range(new_vlan_res, self.services["vlan_ip_range"]) |
| # Add ip range superset to the existing CIDR |
| # Following code finds the netmask superset to existing CIDR |
| cidr = ip2.cidr |
| mask_len = 2 ** (32 - (cidr.prefixlen + 1)) |
| netmask = IPAddress(self.netmask) |
| subset = netmask.__iadd__(mask_len) |
| # Add this superset netmask to services |
| self.services["vlan_ip_range"]["netmask"] = subset |
| self.services["vlan_ip_range"]["startip"] = test_startIp2 |
| self.services["vlan_ip_range"]["endip"] = test_endIp2 |
| self.debug("Adding ip range subset to existing cidr") |
| try: |
| new_vlan2 = PublicIpRange.create( |
| self.apiclient, |
| self.services["vlan_ip_range"]) |
| except CloudstackAPIException as cs: |
| self.debug(cs.errorMsg) |
| self.assertTrue( |
| cs.errorMsg.find("subset") > 0, |
| msg="Fail: CS allowed adding ip range subset to existing CIDR") |
| return |
| # Test will reach here if there is a bug in allowing superset ip range |
| self.cleanup.append(new_vlan2) |
| self.fail( |
| "CS should not allow adding ip range subset to existing CIDR") |
| return |
