commit 0525e4763b7fa991535cea662ed53a41493c427c
author Rajani Karuturi <rajanikaruturi@gmail.com> Tue Apr 07 16:26:38 2015 +0530
committer Rajani Karuturi <rajanikaruturi@gmail.com> Fri Apr 24 15:45:29 2015 +0530
tree 28812e3f172d0fe5296abe246cb000ba8e6e1c67
parent bc399b981f6b9bd7a5471820632e104f6077f7d6

volume-upload: refactored some error messages

services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java

diff --git a/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java b/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
index 7cfaa9c..1cd69fc 100755
--- a/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
+++ b/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
@@ -2613,8 +2613,9 @@
         TemplateOrVolumePostUploadCommand cmd = getTemplateOrVolumePostUploadCmd(metadata);
         UploadEntity uploadEntity = null;
         if(cmd == null ){
-            updateStateMapWithError(uuid,"unable decode and deserialize metadata.");
-            throw new InvalidParameterValueException("unable to decode and deserialize metadata");
+            String errorMessage = "unable decode and deserialize metadata.";
+            updateStateMapWithError(uuid, errorMessage);
+            throw new InvalidParameterValueException(errorMessage);
         } else {
             uuid = cmd.getEntityUUID();
             if (isOneTimePostUrlUsed(cmd)) {
@@ -2628,8 +2629,9 @@
             int maxSizeInGB = Integer.valueOf(cmd.getMaxUploadSize());
             int contentLengthInGB = getSizeInGB(contentLength);
             if (contentLengthInGB > maxSizeInGB) {
-                throw new InvalidParameterValueException("Maximum file upload size exceeded. Content Length received: " + contentLengthInGB + "GB. Maximum allowed size: " +
-                                                             maxSizeInGB + "GB.");
+                String errorMessage = "Maximum file upload size exceeded. Content Length received: " + contentLengthInGB + "GB. Maximum allowed size: " + maxSizeInGB + "GB.";
+                updateStateMapWithError(uuid, errorMessage);
+                throw new InvalidParameterValueException(errorMessage);
             }
             try {
                 String absolutePath = cmd.getAbsolutePath();