| // |
| // Licensed to the Apache Software Foundation (ASF) under one |
| // or more contributor license agreements. See the NOTICE file |
| // distributed with this work for additional information |
| // regarding copyright ownership. The ASF licenses this file |
| // to you under the Apache License, Version 2.0 (the |
| // "License"); you may not use this file except in compliance |
| // with the License. You may obtain a copy of the License at |
| // |
| // http://www.apache.org/licenses/LICENSE-2.0 |
| // |
| // Unless required by applicable law or agreed to in writing, |
| // software distributed under the License is distributed on an |
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY |
| // KIND, either express or implied. See the License for the |
| // specific language governing permissions and limitations |
| // under the License. |
| // |
| |
| package cloudstack |
| |
| import ( |
| "fmt" |
| "strings" |
| "testing" |
| |
| "github.com/apache/cloudstack-go/v2/cloudstack" |
| "github.com/hashicorp/terraform-plugin-testing/helper/resource" |
| "github.com/hashicorp/terraform-plugin-testing/terraform" |
| ) |
| |
| func TestAccCloudStackNetworkACLRule_basic(t *testing.T) { |
| resource.Test(t, resource.TestCase{ |
| PreCheck: func() { testAccPreCheck(t) }, |
| Providers: testAccProviders, |
| CheckDestroy: testAccCheckCloudStackNetworkACLRuleDestroy, |
| Steps: []resource.TestStep{ |
| { |
| Config: testAccCloudStackNetworkACLRule_basic, |
| Check: resource.ComposeTestCheckFunc( |
| |
| testAccCheckCloudStackNetworkACLRulesExist("cloudstack_network_acl.foo"), |
| resource.TestCheckResourceAttr( |
| "cloudstack_network_acl_rule.foo", "rule.#", "4"), |
| // Don't rely on specific rule ordering as TypeSet doesn't guarantee order |
| // Just check that we have the expected rules with their attributes |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "rule_number": "10", |
| "action": "allow", |
| "protocol": "all", |
| "traffic_type": "ingress", |
| "description": "Allow all traffic", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "rule_number": "20", |
| "action": "allow", |
| "protocol": "icmp", |
| "icmp_type": "-1", |
| "icmp_code": "-1", |
| "traffic_type": "ingress", |
| "description": "Allow ICMP traffic", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "action": "allow", |
| "protocol": "tcp", |
| "port": "80", |
| "traffic_type": "ingress", |
| "description": "Allow HTTP", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "action": "allow", |
| "protocol": "tcp", |
| "port": "443", |
| "traffic_type": "ingress", |
| "description": "Allow HTTPS", |
| }), |
| ), |
| }, |
| }, |
| }) |
| } |
| |
| func TestAccCloudStackNetworkACLRule_update(t *testing.T) { |
| resource.Test(t, resource.TestCase{ |
| PreCheck: func() { testAccPreCheck(t) }, |
| Providers: testAccProviders, |
| CheckDestroy: testAccCheckCloudStackNetworkACLRuleDestroy, |
| Steps: []resource.TestStep{ |
| { |
| Config: testAccCloudStackNetworkACLRule_basic, |
| Check: resource.ComposeTestCheckFunc( |
| testAccCheckCloudStackNetworkACLRulesExist("cloudstack_network_acl.foo"), |
| resource.TestCheckResourceAttr( |
| "cloudstack_network_acl_rule.foo", "rule.#", "4"), |
| // Don't rely on specific rule ordering as TypeSet doesn't guarantee order |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "rule_number": "10", |
| "action": "allow", |
| "protocol": "all", |
| "traffic_type": "ingress", |
| "description": "Allow all traffic", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "rule_number": "20", |
| "action": "allow", |
| "protocol": "icmp", |
| "icmp_type": "-1", |
| "icmp_code": "-1", |
| "traffic_type": "ingress", |
| "description": "Allow ICMP traffic", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "action": "allow", |
| "protocol": "tcp", |
| "port": "80", |
| "traffic_type": "ingress", |
| "description": "Allow HTTP", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "action": "allow", |
| "protocol": "tcp", |
| "port": "443", |
| "traffic_type": "ingress", |
| "description": "Allow HTTPS", |
| }), |
| ), |
| }, |
| |
| { |
| Config: testAccCloudStackNetworkACLRule_update, |
| Check: resource.ComposeTestCheckFunc( |
| testAccCheckCloudStackNetworkACLRulesExist("cloudstack_network_acl.foo"), |
| resource.TestCheckResourceAttr( |
| "cloudstack_network_acl_rule.foo", "rule.#", "6"), |
| // Check for the expected rules using TypeSet elem matching |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "action": "deny", |
| "protocol": "all", |
| "traffic_type": "ingress", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "action": "deny", |
| "protocol": "icmp", |
| "icmp_type": "-1", |
| "icmp_code": "-1", |
| "traffic_type": "ingress", |
| "description": "Deny ICMP traffic", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "action": "allow", |
| "protocol": "tcp", |
| "port": "80", |
| "traffic_type": "ingress", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "action": "allow", |
| "protocol": "tcp", |
| "port": "443", |
| "traffic_type": "ingress", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "action": "deny", |
| "protocol": "tcp", |
| "port": "80", |
| "traffic_type": "egress", |
| "description": "Deny specific TCP ports", |
| }), |
| resource.TestCheckTypeSetElemNestedAttrs( |
| "cloudstack_network_acl_rule.foo", "rule.*", map[string]string{ |
| "action": "deny", |
| "protocol": "tcp", |
| "port": "1000-2000", |
| "traffic_type": "egress", |
| "description": "Deny specific TCP ports", |
| }), |
| ), |
| }, |
| }, |
| }) |
| } |
| |
| func testAccCheckCloudStackNetworkACLRulesExist(n string) resource.TestCheckFunc { |
| return func(s *terraform.State) error { |
| rs, ok := s.RootModule().Resources[n] |
| if !ok { |
| return fmt.Errorf("Not found: %s", n) |
| } |
| |
| if rs.Primary.ID == "" { |
| return fmt.Errorf("No network ACL rule ID is set") |
| } |
| |
| for k, id := range rs.Primary.Attributes { |
| if !strings.Contains(k, ".uuids.") || strings.HasSuffix(k, ".uuids.%") { |
| continue |
| } |
| |
| cs := testAccProvider.Meta().(*cloudstack.CloudStackClient) |
| _, count, err := cs.NetworkACL.GetNetworkACLByID(id) |
| |
| if err != nil { |
| return err |
| } |
| |
| if count == 0 { |
| return fmt.Errorf("Network ACL rule %s not found", k) |
| } |
| } |
| |
| return nil |
| } |
| } |
| |
| func testAccCheckCloudStackNetworkACLRuleDestroy(s *terraform.State) error { |
| cs := testAccProvider.Meta().(*cloudstack.CloudStackClient) |
| |
| for _, rs := range s.RootModule().Resources { |
| if rs.Type != "cloudstack_network_acl_rule" { |
| continue |
| } |
| |
| if rs.Primary.ID == "" { |
| return fmt.Errorf("No network ACL rule ID is set") |
| } |
| |
| for k, id := range rs.Primary.Attributes { |
| if !strings.Contains(k, ".uuids.") || strings.HasSuffix(k, ".uuids.%") { |
| continue |
| } |
| |
| _, _, err := cs.NetworkACL.GetNetworkACLByID(id) |
| if err == nil { |
| return fmt.Errorf("Network ACL rule %s still exists", rs.Primary.ID) |
| } |
| } |
| } |
| |
| return nil |
| } |
| |
| const testAccCloudStackNetworkACLRule_basic = ` |
| resource "cloudstack_vpc" "foo" { |
| name = "terraform-vpc" |
| cidr = "10.0.0.0/8" |
| vpc_offering = "Default VPC offering" |
| zone = "Sandbox-simulator" |
| } |
| |
| resource "cloudstack_network_acl" "foo" { |
| name = "terraform-acl" |
| description = "terraform-acl-text" |
| vpc_id = cloudstack_vpc.foo.id |
| } |
| |
| resource "cloudstack_network_acl_rule" "foo" { |
| acl_id = cloudstack_network_acl.foo.id |
| |
| rule { |
| rule_number = 10 |
| action = "allow" |
| cidr_list = ["172.18.100.0/24"] |
| protocol = "all" |
| traffic_type = "ingress" |
| description = "Allow all traffic" |
| } |
| |
| rule { |
| rule_number = 20 |
| action = "allow" |
| cidr_list = ["172.18.100.0/24"] |
| protocol = "icmp" |
| icmp_type = "-1" |
| icmp_code = "-1" |
| traffic_type = "ingress" |
| description = "Allow ICMP traffic" |
| } |
| |
| rule { |
| cidr_list = ["172.16.100.0/24"] |
| protocol = "tcp" |
| port = "80" |
| traffic_type = "ingress" |
| description = "Allow HTTP" |
| } |
| |
| rule { |
| cidr_list = ["172.16.100.0/24"] |
| protocol = "tcp" |
| port = "443" |
| traffic_type = "ingress" |
| description = "Allow HTTPS" |
| } |
| }` |
| |
| const testAccCloudStackNetworkACLRule_update = ` |
| resource "cloudstack_vpc" "foo" { |
| name = "terraform-vpc" |
| cidr = "10.0.0.0/8" |
| vpc_offering = "Default VPC offering" |
| zone = "Sandbox-simulator" |
| } |
| |
| resource "cloudstack_network_acl" "foo" { |
| name = "terraform-acl" |
| description = "terraform-acl-text" |
| vpc_id = cloudstack_vpc.foo.id |
| } |
| |
| resource "cloudstack_network_acl_rule" "foo" { |
| acl_id = cloudstack_network_acl.foo.id |
| |
| rule { |
| action = "deny" |
| cidr_list = ["172.18.100.0/24"] |
| protocol = "all" |
| traffic_type = "ingress" |
| } |
| |
| rule { |
| action = "deny" |
| cidr_list = ["172.18.100.0/24", "172.18.101.0/24"] |
| protocol = "icmp" |
| icmp_type = "-1" |
| icmp_code = "-1" |
| traffic_type = "ingress" |
| description = "Deny ICMP traffic" |
| } |
| |
| rule { |
| action = "allow" |
| cidr_list = ["172.18.100.0/24"] |
| protocol = "tcp" |
| port = "80" |
| traffic_type = "ingress" |
| } |
| |
| rule { |
| cidr_list = ["172.16.100.0/24"] |
| protocol = "tcp" |
| port = "443" |
| traffic_type = "ingress" |
| } |
| |
| rule { |
| action = "deny" |
| cidr_list = ["10.0.0.0/24"] |
| protocol = "tcp" |
| port = "80" |
| traffic_type = "egress" |
| description = "Deny specific TCP ports" |
| } |
| |
| rule { |
| action = "deny" |
| cidr_list = ["10.0.0.0/24"] |
| protocol = "tcp" |
| port = "1000-2000" |
| traffic_type = "egress" |
| description = "Deny specific TCP ports" |
| } |
| }` |
