vendor/k8s.io/kubernetes/pkg/util/mount/nsenter_mount_test.go - cloudstack-kubernetes-provider - Git at Google

 // +build linux

 /*
 Copyright 2017 The Kubernetes Authors.

 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at

     http://www.apache.org/licenses/LICENSE-2.0

 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 */

 package mount

 import (
 	"io/ioutil"
 	"os"
 	"os/user"
 	"path/filepath"
 	"strings"
 	"testing"

 	"golang.org/x/sys/unix"
 	"k8s.io/kubernetes/pkg/util/nsenter"
 )

 func TestParseFindMnt(t *testing.T) {
 	tests := []struct {
 		input       string
 		target      string
 		expectError bool
 	}{
 		{
 			// standard mount name, e.g. for AWS
 			"/var/lib/kubelet/plugins/kubernetes.io/aws-ebs/mounts/aws/us-east-1d/vol-020f82b0759f72389 ext4\n",
 			"/var/lib/kubelet/plugins/kubernetes.io/aws-ebs/mounts/aws/us-east-1d/vol-020f82b0759f72389",
 			false,
 		},
 		{
 			// mount name with space, e.g. vSphere
 			"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[datastore1] kubevols/kubernetes-dynamic-pvc-4aacaa9b-6ba5-11e7-8f64-0050569f1b82.vmdk ext2\n",
 			"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[datastore1] kubevols/kubernetes-dynamic-pvc-4aacaa9b-6ba5-11e7-8f64-0050569f1b82.vmdk",
 			false,
 		},
 		{
 			// hypotetic mount with several spaces
 			"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[ d a t a s t o r e 1 ] kubevols/kubernetes-dynamic-pvc-4aacaa9b-6ba5-11e7-8f64-0050569f1b82.vmdk ext2\n",
 			"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[ d a t a s t o r e 1 ] kubevols/kubernetes-dynamic-pvc-4aacaa9b-6ba5-11e7-8f64-0050569f1b82.vmdk",
 			false,
 		},
 		{
 			// invalid output - no filesystem type
 			"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/blabla",
 			"",
 			true,
 		},
 	}

 	for i, test := range tests {
 		target, err := parseFindMnt(test.input)
 		if test.expectError && err == nil {
 			t.Errorf("test %d expected error, got nil", i)
 		}
 		if !test.expectError && err != nil {
 			t.Errorf("test %d returned error: %s", i, err)
 		}
 		if target != test.target {
 			t.Errorf("test %d expected %q, got %q", i, test.target, target)
 		}
 	}
 }

 func TestCheckDeviceInode(t *testing.T) {
 	testDir, err := ioutil.TempDir("", "nsenter-mounter-device-")
 	if err != nil {
 		t.Fatalf("Cannot create temporary directory: %s", err)
 	}
 	defer os.RemoveAll(testDir)

 	tests := []struct {
 		name        string
 		srcPath     string
 		dstPath     string
 		expectError string
 	}{
 		{
 			name:        "the same file",
 			srcPath:     filepath.Join(testDir, "1"),
 			dstPath:     filepath.Join(testDir, "1"),
 			expectError: "",
 		},
 		{
 			name:        "different file on the same FS",
 			srcPath:     filepath.Join(testDir, "2.1"),
 			dstPath:     filepath.Join(testDir, "2.2"),
 			expectError: "different inode",
 		},
 		{
 			name:    "different file on different device",
 			srcPath: filepath.Join(testDir, "3"),
 			// /proc is always on a different "device" than /tmp (or $TEMP)
 			dstPath:     "/proc/self/status",
 			expectError: "different device",
 		},
 	}

 	for _, test := range tests {
 		if err := ioutil.WriteFile(test.srcPath, []byte{}, 0644); err != nil {
 			t.Errorf("Test %q: cannot create srcPath %s: %s", test.name, test.srcPath, err)
 			continue
 		}

 		// Don't create dst if it exists
 		if _, err := os.Stat(test.dstPath); os.IsNotExist(err) {
 			if err := ioutil.WriteFile(test.dstPath, []byte{}, 0644); err != nil {
 				t.Errorf("Test %q: cannot create dstPath %s: %s", test.name, test.dstPath, err)
 				continue
 			}
 		} else if err != nil {
 			t.Errorf("Test %q: cannot check existence of dstPath %s: %s", test.name, test.dstPath, err)
 			continue
 		}

 		fd, err := unix.Open(test.srcPath, unix.O_CREAT, 0644)
 		if err != nil {
 			t.Errorf("Test %q: cannot open srcPath %s: %s", test.name, test.srcPath, err)
 			continue
 		}

 		err = checkDeviceInode(fd, test.dstPath)

 		if test.expectError == "" && err != nil {
 			t.Errorf("Test %q: expected no error, got %s", test.name, err)
 		}
 		if test.expectError != "" {
 			if err == nil {
 				t.Errorf("Test %q: expected error, got none", test.name)
 			} else {
 				if !strings.Contains(err.Error(), test.expectError) {
 					t.Errorf("Test %q: expected error %q, got %q", test.name, test.expectError, err)
 				}
 			}
 		}
 	}
 }

 func newFakeNsenterMounter(tmpdir string, t *testing.T) (mounter *NsenterMounter, rootfsPath string, varlibPath string, err error) {
 	rootfsPath = filepath.Join(tmpdir, "rootfs")
 	if err := os.Mkdir(rootfsPath, 0755); err != nil {
 		return nil, "", "", err
 	}
 	ne, err := nsenter.NewFakeNsenter(rootfsPath)
 	if err != nil {
 		return nil, "", "", err
 	}

 	varlibPath = filepath.Join(tmpdir, "/var/lib/kubelet")
 	if err := os.MkdirAll(varlibPath, 0755); err != nil {
 		return nil, "", "", err
 	}

 	return NewNsenterMounter(varlibPath, ne), rootfsPath, varlibPath, nil
 }

 func TestNsenterExistsFile(t *testing.T) {
 	user, err := user.Current()
 	if err != nil {
 		t.Error(err)
 	}
 	isRoot := user.Username == "root"

 	tests := []struct {
 		name           string
 		prepare        func(base, rootfs string) (string, error)
 		expectedOutput bool
 		expectError    bool
 	}{
 		{
 			name: "simple existing file",
 			prepare: func(base, rootfs string) (string, error) {
 				// On the host: /base/file
 				path := filepath.Join(base, "file")
 				if err := ioutil.WriteFile(path, []byte{}, 0644); err != nil {
 					return "", err
 				}
 				// In kubelet: /rootfs/base/file
 				if _, err := writeRootfsFile(rootfs, path, 0644); err != nil {
 					return "", err
 				}
 				return path, nil
 			},
 			expectedOutput: true,
 		},
 		{
 			name: "simple non-existing file",
 			prepare: func(base, rootfs string) (string, error) {
 				path := filepath.Join(base, "file")
 				return path, nil
 			},
 			expectedOutput: false,
 		},
 		{
 			name: "simple non-accessible file",
 			prepare: func(base, rootfs string) (string, error) {
 				// On the host:
 				// create /base/dir/file, then make the dir inaccessible
 				dir := filepath.Join(base, "dir")
 				if err := os.MkdirAll(dir, 0755); err != nil {
 					return "", err
 				}
 				path := filepath.Join(dir, "file")
 				if err := ioutil.WriteFile(path, []byte{}, 0); err != nil {
 					return "", err
 				}
 				if err := os.Chmod(dir, 0644); err != nil {
 					return "", err
 				}

 				// In kubelet: do the same with /rootfs/base/dir/file
 				rootfsPath, err := writeRootfsFile(rootfs, path, 0777)
 				if err != nil {
 					return "", err
 				}
 				rootfsDir := filepath.Dir(rootfsPath)
 				if err := os.Chmod(rootfsDir, 0644); err != nil {
 					return "", err
 				}

 				return path, nil
 			},
 			expectedOutput: isRoot,  // ExistsPath success when running as root
 			expectError:    !isRoot, // ExistsPath must fail when running as not-root
 		},
 		{
 			name: "relative symlink to existing file",
 			prepare: func(base, rootfs string) (string, error) {
 				// On the host: /base/link -> file
 				file := filepath.Join(base, "file")
 				if err := ioutil.WriteFile(file, []byte{}, 0); err != nil {
 					return "", err
 				}
 				path := filepath.Join(base, "link")
 				if err := os.Symlink("file", path); err != nil {
 					return "", err
 				}
 				// In kubelet: /rootfs/base/file
 				if _, err := writeRootfsFile(rootfs, file, 0644); err != nil {
 					return "", err
 				}
 				return path, nil
 			},
 			expectedOutput: true,
 		},
 		{
 			name: "absolute symlink to existing file",
 			prepare: func(base, rootfs string) (string, error) {
 				// On the host: /base/link -> /base/file
 				file := filepath.Join(base, "file")
 				if err := ioutil.WriteFile(file, []byte{}, 0); err != nil {
 					return "", err
 				}
 				path := filepath.Join(base, "link")
 				if err := os.Symlink(file, path); err != nil {
 					return "", err
 				}
 				// In kubelet: /rootfs/base/file
 				if _, err := writeRootfsFile(rootfs, file, 0644); err != nil {
 					return "", err
 				}

 				return path, nil
 			},
 			expectedOutput: true,
 		},
 		{
 			name: "relative symlink to non-existing file",
 			prepare: func(base, rootfs string) (string, error) {
 				path := filepath.Join(base, "link")
 				if err := os.Symlink("file", path); err != nil {
 					return "", err
 				}
 				return path, nil
 			},
 			expectedOutput: false,
 		},
 		{
 			name: "absolute symlink to non-existing file",
 			prepare: func(base, rootfs string) (string, error) {
 				file := filepath.Join(base, "file")
 				path := filepath.Join(base, "link")
 				if err := os.Symlink(file, path); err != nil {
 					return "", err
 				}
 				return path, nil
 			},
 			expectedOutput: false,
 		},
 		{
 			name: "symlink loop",
 			prepare: func(base, rootfs string) (string, error) {
 				path := filepath.Join(base, "link")
 				if err := os.Symlink(path, path); err != nil {
 					return "", err
 				}
 				return path, nil
 			},
 			expectedOutput: false,
 			// TODO: realpath -m is not able to detect symlink loop. Should we care?
 			expectError: false,
 		},
 	}

 	for _, test := range tests {
 		tmpdir, err := ioutil.TempDir("", "nsenter-exists-file")
 		if err != nil {
 			t.Error(err)
 			continue
 		}
 		defer os.RemoveAll(tmpdir)

 		testBase := filepath.Join(tmpdir, "base")
 		if err := os.Mkdir(testBase, 0755); err != nil {
 			t.Error(err)
 			continue
 		}

 		mounter, rootfs, _, err := newFakeNsenterMounter(tmpdir, t)
 		if err != nil {
 			t.Error(err)
 			continue
 		}

 		path, err := test.prepare(testBase, rootfs)
 		if err != nil {
 			t.Error(err)
 			continue
 		}

 		out, err := mounter.ExistsPath(path)
 		if err != nil && !test.expectError {
 			t.Errorf("Test %q: unexpected error: %s", test.name, err)
 		}
 		if err == nil && test.expectError {
 			t.Errorf("Test %q: expected error, got none", test.name)
 		}

 		if out != test.expectedOutput {
 			t.Errorf("Test %q: expected return value %v, got %v", test.name, test.expectedOutput, out)
 		}
 	}
 }

 func TestNsenterGetMode(t *testing.T) {
 	tests := []struct {
 		name         string
 		prepare      func(base, rootfs string) (string, error)
 		expectedMode os.FileMode
 		expectError  bool
 	}{
 		{
 			name: "simple file",
 			prepare: func(base, rootfs string) (string, error) {
 				// On the host: /base/file
 				path := filepath.Join(base, "file")
 				if err := ioutil.WriteFile(path, []byte{}, 0644); err != nil {
 					return "", err
 				}

 				// Prepare a different file as /rootfs/base/file (="the host
 				// visible from container") to check that NsEnterMounter calls
 				// stat on this file and not on /base/file.
 				// Visible from kubelet: /rootfs/base/file
 				if _, err := writeRootfsFile(rootfs, path, 0777); err != nil {
 					return "", err
 				}

 				return path, nil
 			},
 			expectedMode: 0777,
 		},
 		{
 			name: "non-existing file",
 			prepare: func(base, rootfs string) (string, error) {
 				path := filepath.Join(base, "file")
 				return path, nil
 			},
 			expectedMode: 0,
 			expectError:  true,
 		},
 		{
 			name: "absolute symlink to existing file",
 			prepare: func(base, rootfs string) (string, error) {
 				// On the host: /base/link -> /base/file
 				file := filepath.Join(base, "file")
 				if err := ioutil.WriteFile(file, []byte{}, 0644); err != nil {
 					return "", err
 				}
 				path := filepath.Join(base, "link")
 				if err := os.Symlink(file, path); err != nil {
 					return "", err
 				}

 				// Visible from kubelet:
 				// /rootfs/base/file
 				if _, err := writeRootfsFile(rootfs, file, 0747); err != nil {
 					return "", err
 				}

 				return path, nil
 			},
 			expectedMode: 0747,
 		},
 		{
 			name: "relative symlink to existing file",
 			prepare: func(base, rootfs string) (string, error) {
 				// On the host: /base/link -> file
 				file := filepath.Join(base, "file")
 				if err := ioutil.WriteFile(file, []byte{}, 0741); err != nil {
 					return "", err
 				}
 				path := filepath.Join(base, "link")
 				if err := os.Symlink("file", path); err != nil {
 					return "", err
 				}

 				// Visible from kubelet:
 				// /rootfs/base/file
 				if _, err := writeRootfsFile(rootfs, file, 0647); err != nil {
 					return "", err
 				}

 				return path, nil
 			},
 			expectedMode: 0647,
 		},
 	}

 	for _, test := range tests {
 		tmpdir, err := ioutil.TempDir("", "nsenter-get-mode-")
 		if err != nil {
 			t.Error(err)
 			continue
 		}
 		defer os.RemoveAll(tmpdir)

 		testBase := filepath.Join(tmpdir, "base")
 		if err := os.Mkdir(testBase, 0755); err != nil {
 			t.Error(err)
 			continue
 		}

 		mounter, rootfs, _, err := newFakeNsenterMounter(tmpdir, t)
 		if err != nil {
 			t.Error(err)
 			continue
 		}

 		path, err := test.prepare(testBase, rootfs)
 		if err != nil {
 			t.Error(err)
 			continue
 		}

 		mode, err := mounter.GetMode(path)
 		if err != nil && !test.expectError {
 			t.Errorf("Test %q: unexpected error: %s", test.name, err)
 		}
 		if err == nil && test.expectError {
 			t.Errorf("Test %q: expected error, got none", test.name)
 		}

 		if mode != test.expectedMode {
 			t.Errorf("Test %q: expected return value %v, got %v", test.name, test.expectedMode, mode)
 		}
 	}
 }

 func writeRootfsFile(rootfs, path string, mode os.FileMode) (string, error) {
 	fullPath := filepath.Join(rootfs, path)
 	dir := filepath.Dir(fullPath)
 	if err := os.MkdirAll(dir, 0755); err != nil {
 		return "", err
 	}
 	if err := ioutil.WriteFile(fullPath, []byte{}, mode); err != nil {
 		return "", err
 	}
 	// Use chmod, io.WriteFile is affected by umask
 	if err := os.Chmod(fullPath, mode); err != nil {
 		return "", err
 	}
 	return fullPath, nil
 }

 func TestNsenterSafeMakeDir(t *testing.T) {
 	tests := []struct {
 		name        string
 		prepare     func(base, rootfs, varlib string) (expectedDir string, err error)
 		subdir      string
 		expectError bool
 		// If true, "base" directory for SafeMakeDir will be /var/lib/kubelet
 		baseIsVarLib bool
 	}{
 		{
 			name: "simple directory",
 			// evaluated in base
 			subdir: "some/subdirectory/structure",
 			prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
 				// expected to be created in /roots/
 				expectedDir = filepath.Join(rootfs, base, "some/subdirectory/structure")
 				return expectedDir, nil
 			},
 		},
 		{
 			name: "simple existing directory",
 			// evaluated in base
 			subdir: "some/subdirectory/structure",
 			prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
 				// On the host: directory exists
 				hostPath := filepath.Join(base, "some/subdirectory/structure")
 				if err := os.MkdirAll(hostPath, 0755); err != nil {
 					return "", err
 				}
 				// In rootfs: directory exists
 				kubeletPath := filepath.Join(rootfs, hostPath)
 				if err := os.MkdirAll(kubeletPath, 0755); err != nil {
 					return "", err
 				}
 				// expected to be created in /roots/
 				expectedDir = kubeletPath
 				return expectedDir, nil
 			},
 		},
 		{
 			name: "absolute symlink into safe place",
 			// evaluated in base
 			subdir: "some/subdirectory/structure",
 			prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
 				// On the host: /base/other/subdirectory exists, /base/some is link to /base/other
 				hostPath := filepath.Join(base, "other/subdirectory")
 				if err := os.MkdirAll(hostPath, 0755); err != nil {
 					return "", err
 				}
 				somePath := filepath.Join(base, "some")
 				otherPath := filepath.Join(base, "other")
 				if err := os.Symlink(otherPath, somePath); err != nil {
 					return "", err
 				}

 				// In rootfs: /base/other/subdirectory exists
 				kubeletPath := filepath.Join(rootfs, hostPath)
 				if err := os.MkdirAll(kubeletPath, 0755); err != nil {
 					return "", err
 				}
 				// expected 'structure' to be created
 				expectedDir = filepath.Join(rootfs, hostPath, "structure")
 				return expectedDir, nil
 			},
 		},
 		{
 			name: "relative symlink into safe place",
 			// evaluated in base
 			subdir: "some/subdirectory/structure",
 			prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
 				// On the host: /base/other/subdirectory exists, /base/some is link to other
 				hostPath := filepath.Join(base, "other/subdirectory")
 				if err := os.MkdirAll(hostPath, 0755); err != nil {
 					return "", err
 				}
 				somePath := filepath.Join(base, "some")
 				if err := os.Symlink("other", somePath); err != nil {
 					return "", err
 				}

 				// In rootfs: /base/other/subdirectory exists
 				kubeletPath := filepath.Join(rootfs, hostPath)
 				if err := os.MkdirAll(kubeletPath, 0755); err != nil {
 					return "", err
 				}
 				// expected 'structure' to be created
 				expectedDir = filepath.Join(rootfs, hostPath, "structure")
 				return expectedDir, nil
 			},
 		},
 		{
 			name: "symlink into unsafe place",
 			// evaluated in base
 			subdir: "some/subdirectory/structure",
 			prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
 				// On the host: /base/some is link to /bin/other
 				somePath := filepath.Join(base, "some")
 				if err := os.Symlink("/bin", somePath); err != nil {
 					return "", err
 				}
 				return "", nil
 			},
 			expectError: true,
 		},
 		{
 			name: "simple directory in /var/lib/kubelet",
 			// evaluated in varlib
 			subdir:       "some/subdirectory/structure",
 			baseIsVarLib: true,
 			prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
 				// expected to be created in /base/var/lib/kubelet, not in /rootfs!
 				expectedDir = filepath.Join(varlib, "some/subdirectory/structure")
 				return expectedDir, nil
 			},
 		},
 		{
 			name: "safe symlink in /var/lib/kubelet",
 			// evaluated in varlib
 			subdir:       "some/subdirectory/structure",
 			baseIsVarLib: true,
 			prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
 				// On the host: /varlib/kubelet/other/subdirectory exists, /varlib/some is link to other
 				hostPath := filepath.Join(varlib, "other/subdirectory")
 				if err := os.MkdirAll(hostPath, 0755); err != nil {
 					return "", err
 				}
 				somePath := filepath.Join(varlib, "some")
 				if err := os.Symlink("other", somePath); err != nil {
 					return "", err
 				}

 				// expected to be created in /base/var/lib/kubelet, not in /rootfs!
 				expectedDir = filepath.Join(varlib, "other/subdirectory/structure")
 				return expectedDir, nil
 			},
 		},
 		{
 			name: "unsafe symlink in /var/lib/kubelet",
 			// evaluated in varlib
 			subdir:       "some/subdirectory/structure",
 			baseIsVarLib: true,
 			prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
 				// On the host: /varlib/some is link to /bin
 				somePath := filepath.Join(varlib, "some")
 				if err := os.Symlink("/bin", somePath); err != nil {
 					return "", err
 				}

 				return "", nil
 			},
 			expectError: true,
 		},
 	}
 	for _, test := range tests {
 		tmpdir, err := ioutil.TempDir("", "nsenter-get-mode-")
 		if err != nil {
 			t.Error(err)
 			continue
 		}
 		defer os.RemoveAll(tmpdir)

 		mounter, rootfs, varlib, err := newFakeNsenterMounter(tmpdir, t)
 		if err != nil {
 			t.Error(err)
 			continue
 		}
 		// Prepare base directory for the test
 		testBase := filepath.Join(tmpdir, "base")
 		if err := os.Mkdir(testBase, 0755); err != nil {
 			t.Error(err)
 			continue
 		}
 		// Prepare base directory also in /rootfs
 		rootfsBase := filepath.Join(rootfs, testBase)
 		if err := os.MkdirAll(rootfsBase, 0755); err != nil {
 			t.Error(err)
 			continue
 		}

 		expectedDir := ""
 		if test.prepare != nil {
 			expectedDir, err = test.prepare(testBase, rootfs, varlib)
 			if err != nil {
 				t.Error(err)
 				continue
 			}
 		}

 		if test.baseIsVarLib {
 			// use /var/lib/kubelet as the test base so we can test creating
 			// subdirs there directly in /var/lib/kubenet and not in
 			// /rootfs/var/lib/kubelet
 			testBase = varlib
 		}

 		err = mounter.SafeMakeDir(test.subdir, testBase, 0755)
 		if err != nil && !test.expectError {
 			t.Errorf("Test %q: unexpected error: %s", test.name, err)
 		}
 		if test.expectError {
 			if err == nil {
 				t.Errorf("Test %q: expected error, got none", test.name)
 			} else {
 				if !strings.Contains(err.Error(), "is outside of allowed base") {
 					t.Errorf("Test %q: expected error to contain \"is outside of allowed base\", got this one instead: %s", test.name, err)
 				}
 			}
 		}

 		if expectedDir != "" {
 			_, err := os.Stat(expectedDir)
 			if err != nil {
 				t.Errorf("Test %q: expected %q to exist, got error: %s", test.name, expectedDir, err)
 			}
 		}
 	}
 }
	// +build linux

	/*
	Copyright 2017 The Kubernetes Authors.

	Licensed under the Apache License, Version 2.0 (the "License");
	you may not use this file except in compliance with the License.
	You may obtain a copy of the License at

	http://www.apache.org/licenses/LICENSE-2.0

	Unless required by applicable law or agreed to in writing, software
	distributed under the License is distributed on an "AS IS" BASIS,
	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	See the License for the specific language governing permissions and
	limitations under the License.
	*/

	package mount

	import (
	"io/ioutil"
	"os"
	"os/user"
	"path/filepath"
	"strings"
	"testing"

	"golang.org/x/sys/unix"
	"k8s.io/kubernetes/pkg/util/nsenter"
	)

	func TestParseFindMnt(t *testing.T) {
	tests := []struct {
	input string
	target string
	expectError bool
	}{
	{
	// standard mount name, e.g. for AWS
	"/var/lib/kubelet/plugins/kubernetes.io/aws-ebs/mounts/aws/us-east-1d/vol-020f82b0759f72389 ext4\n",
	"/var/lib/kubelet/plugins/kubernetes.io/aws-ebs/mounts/aws/us-east-1d/vol-020f82b0759f72389",
	false,
	},
	{
	// mount name with space, e.g. vSphere
	"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[datastore1] kubevols/kubernetes-dynamic-pvc-4aacaa9b-6ba5-11e7-8f64-0050569f1b82.vmdk ext2\n",
	"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[datastore1] kubevols/kubernetes-dynamic-pvc-4aacaa9b-6ba5-11e7-8f64-0050569f1b82.vmdk",
	false,
	},
	{
	// hypotetic mount with several spaces
	"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[ d a t a s t o r e 1 ] kubevols/kubernetes-dynamic-pvc-4aacaa9b-6ba5-11e7-8f64-0050569f1b82.vmdk ext2\n",
	"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[ d a t a s t o r e 1 ] kubevols/kubernetes-dynamic-pvc-4aacaa9b-6ba5-11e7-8f64-0050569f1b82.vmdk",
	false,
	},
	{
	// invalid output - no filesystem type
	"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/blabla",
	"",
	true,
	},
	}

	for i, test := range tests {
	target, err := parseFindMnt(test.input)
	if test.expectError && err == nil {
	t.Errorf("test %d expected error, got nil", i)
	}
	if !test.expectError && err != nil {
	t.Errorf("test %d returned error: %s", i, err)
	}
	if target != test.target {
	t.Errorf("test %d expected %q, got %q", i, test.target, target)
	}
	}
	}

	func TestCheckDeviceInode(t *testing.T) {
	testDir, err := ioutil.TempDir("", "nsenter-mounter-device-")
	if err != nil {
	t.Fatalf("Cannot create temporary directory: %s", err)
	}
	defer os.RemoveAll(testDir)

	tests := []struct {
	name string
	srcPath string
	dstPath string
	expectError string
	}{
	{
	name: "the same file",
	srcPath: filepath.Join(testDir, "1"),
	dstPath: filepath.Join(testDir, "1"),
	expectError: "",
	},
	{
	name: "different file on the same FS",
	srcPath: filepath.Join(testDir, "2.1"),
	dstPath: filepath.Join(testDir, "2.2"),
	expectError: "different inode",
	},
	{
	name: "different file on different device",
	srcPath: filepath.Join(testDir, "3"),
	// /proc is always on a different "device" than /tmp (or $TEMP)
	dstPath: "/proc/self/status",
	expectError: "different device",
	},
	}

	for _, test := range tests {
	if err := ioutil.WriteFile(test.srcPath, []byte{}, 0644); err != nil {
	t.Errorf("Test %q: cannot create srcPath %s: %s", test.name, test.srcPath, err)
	continue
	}

	// Don't create dst if it exists
	if _, err := os.Stat(test.dstPath); os.IsNotExist(err) {
	if err := ioutil.WriteFile(test.dstPath, []byte{}, 0644); err != nil {
	t.Errorf("Test %q: cannot create dstPath %s: %s", test.name, test.dstPath, err)
	continue
	}
	} else if err != nil {
	t.Errorf("Test %q: cannot check existence of dstPath %s: %s", test.name, test.dstPath, err)
	continue
	}

	fd, err := unix.Open(test.srcPath, unix.O_CREAT, 0644)
	if err != nil {
	t.Errorf("Test %q: cannot open srcPath %s: %s", test.name, test.srcPath, err)
	continue
	}

	err = checkDeviceInode(fd, test.dstPath)

	if test.expectError == "" && err != nil {
	t.Errorf("Test %q: expected no error, got %s", test.name, err)
	}
	if test.expectError != "" {
	if err == nil {
	t.Errorf("Test %q: expected error, got none", test.name)
	} else {
	if !strings.Contains(err.Error(), test.expectError) {
	t.Errorf("Test %q: expected error %q, got %q", test.name, test.expectError, err)
	}
	}
	}
	}
	}

	func newFakeNsenterMounter(tmpdir string, t testing.T) (mounter NsenterMounter, rootfsPath string, varlibPath string, err error) {
	rootfsPath = filepath.Join(tmpdir, "rootfs")
	if err := os.Mkdir(rootfsPath, 0755); err != nil {
	return nil, "", "", err
	}
	ne, err := nsenter.NewFakeNsenter(rootfsPath)
	if err != nil {
	return nil, "", "", err
	}

	varlibPath = filepath.Join(tmpdir, "/var/lib/kubelet")
	if err := os.MkdirAll(varlibPath, 0755); err != nil {
	return nil, "", "", err
	}

	return NewNsenterMounter(varlibPath, ne), rootfsPath, varlibPath, nil
	}

	func TestNsenterExistsFile(t *testing.T) {
	user, err := user.Current()
	if err != nil {
	t.Error(err)
	}
	isRoot := user.Username == "root"

	tests := []struct {
	name string
	prepare func(base, rootfs string) (string, error)
	expectedOutput bool
	expectError bool
	}{
	{
	name: "simple existing file",
	prepare: func(base, rootfs string) (string, error) {
	// On the host: /base/file
	path := filepath.Join(base, "file")
	if err := ioutil.WriteFile(path, []byte{}, 0644); err != nil {
	return "", err
	}
	// In kubelet: /rootfs/base/file
	if _, err := writeRootfsFile(rootfs, path, 0644); err != nil {
	return "", err
	}
	return path, nil
	},
	expectedOutput: true,
	},
	{
	name: "simple non-existing file",
	prepare: func(base, rootfs string) (string, error) {
	path := filepath.Join(base, "file")
	return path, nil
	},
	expectedOutput: false,
	},
	{
	name: "simple non-accessible file",
	prepare: func(base, rootfs string) (string, error) {
	// On the host:
	// create /base/dir/file, then make the dir inaccessible
	dir := filepath.Join(base, "dir")
	if err := os.MkdirAll(dir, 0755); err != nil {
	return "", err
	}
	path := filepath.Join(dir, "file")
	if err := ioutil.WriteFile(path, []byte{}, 0); err != nil {
	return "", err
	}
	if err := os.Chmod(dir, 0644); err != nil {
	return "", err
	}

	// In kubelet: do the same with /rootfs/base/dir/file
	rootfsPath, err := writeRootfsFile(rootfs, path, 0777)
	if err != nil {
	return "", err
	}
	rootfsDir := filepath.Dir(rootfsPath)
	if err := os.Chmod(rootfsDir, 0644); err != nil {
	return "", err
	}

	return path, nil
	},
	expectedOutput: isRoot, // ExistsPath success when running as root
	expectError: !isRoot, // ExistsPath must fail when running as not-root
	},
	{
	name: "relative symlink to existing file",
	prepare: func(base, rootfs string) (string, error) {
	// On the host: /base/link -> file
	file := filepath.Join(base, "file")
	if err := ioutil.WriteFile(file, []byte{}, 0); err != nil {
	return "", err
	}
	path := filepath.Join(base, "link")
	if err := os.Symlink("file", path); err != nil {
	return "", err
	}
	// In kubelet: /rootfs/base/file
	if _, err := writeRootfsFile(rootfs, file, 0644); err != nil {
	return "", err
	}
	return path, nil
	},
	expectedOutput: true,
	},
	{
	name: "absolute symlink to existing file",
	prepare: func(base, rootfs string) (string, error) {
	// On the host: /base/link -> /base/file
	file := filepath.Join(base, "file")
	if err := ioutil.WriteFile(file, []byte{}, 0); err != nil {
	return "", err
	}
	path := filepath.Join(base, "link")
	if err := os.Symlink(file, path); err != nil {
	return "", err
	}
	// In kubelet: /rootfs/base/file
	if _, err := writeRootfsFile(rootfs, file, 0644); err != nil {
	return "", err
	}

	return path, nil
	},
	expectedOutput: true,
	},
	{
	name: "relative symlink to non-existing file",
	prepare: func(base, rootfs string) (string, error) {
	path := filepath.Join(base, "link")
	if err := os.Symlink("file", path); err != nil {
	return "", err
	}
	return path, nil
	},
	expectedOutput: false,
	},
	{
	name: "absolute symlink to non-existing file",
	prepare: func(base, rootfs string) (string, error) {
	file := filepath.Join(base, "file")
	path := filepath.Join(base, "link")
	if err := os.Symlink(file, path); err != nil {
	return "", err
	}
	return path, nil
	},
	expectedOutput: false,
	},
	{
	name: "symlink loop",
	prepare: func(base, rootfs string) (string, error) {
	path := filepath.Join(base, "link")
	if err := os.Symlink(path, path); err != nil {
	return "", err
	}
	return path, nil
	},
	expectedOutput: false,
	// TODO: realpath -m is not able to detect symlink loop. Should we care?
	expectError: false,
	},
	}

	for _, test := range tests {
	tmpdir, err := ioutil.TempDir("", "nsenter-exists-file")
	if err != nil {
	t.Error(err)
	continue
	}
	defer os.RemoveAll(tmpdir)

	testBase := filepath.Join(tmpdir, "base")
	if err := os.Mkdir(testBase, 0755); err != nil {
	t.Error(err)
	continue
	}

	mounter, rootfs, _, err := newFakeNsenterMounter(tmpdir, t)
	if err != nil {
	t.Error(err)
	continue
	}

	path, err := test.prepare(testBase, rootfs)
	if err != nil {
	t.Error(err)
	continue
	}

	out, err := mounter.ExistsPath(path)
	if err != nil && !test.expectError {
	t.Errorf("Test %q: unexpected error: %s", test.name, err)
	}
	if err == nil && test.expectError {
	t.Errorf("Test %q: expected error, got none", test.name)
	}

	if out != test.expectedOutput {
	t.Errorf("Test %q: expected return value %v, got %v", test.name, test.expectedOutput, out)
	}
	}
	}

	func TestNsenterGetMode(t *testing.T) {
	tests := []struct {
	name string
	prepare func(base, rootfs string) (string, error)
	expectedMode os.FileMode
	expectError bool
	}{
	{
	name: "simple file",
	prepare: func(base, rootfs string) (string, error) {
	// On the host: /base/file
	path := filepath.Join(base, "file")
	if err := ioutil.WriteFile(path, []byte{}, 0644); err != nil {
	return "", err
	}

	// Prepare a different file as /rootfs/base/file (="the host
	// visible from container") to check that NsEnterMounter calls
	// stat on this file and not on /base/file.
	// Visible from kubelet: /rootfs/base/file
	if _, err := writeRootfsFile(rootfs, path, 0777); err != nil {
	return "", err
	}

	return path, nil
	},
	expectedMode: 0777,
	},
	{
	name: "non-existing file",
	prepare: func(base, rootfs string) (string, error) {
	path := filepath.Join(base, "file")
	return path, nil
	},
	expectedMode: 0,
	expectError: true,
	},
	{
	name: "absolute symlink to existing file",
	prepare: func(base, rootfs string) (string, error) {
	// On the host: /base/link -> /base/file
	file := filepath.Join(base, "file")
	if err := ioutil.WriteFile(file, []byte{}, 0644); err != nil {
	return "", err
	}
	path := filepath.Join(base, "link")
	if err := os.Symlink(file, path); err != nil {
	return "", err
	}

	// Visible from kubelet:
	// /rootfs/base/file
	if _, err := writeRootfsFile(rootfs, file, 0747); err != nil {
	return "", err
	}

	return path, nil
	},
	expectedMode: 0747,
	},
	{
	name: "relative symlink to existing file",
	prepare: func(base, rootfs string) (string, error) {
	// On the host: /base/link -> file
	file := filepath.Join(base, "file")
	if err := ioutil.WriteFile(file, []byte{}, 0741); err != nil {
	return "", err
	}
	path := filepath.Join(base, "link")
	if err := os.Symlink("file", path); err != nil {
	return "", err
	}

	// Visible from kubelet:
	// /rootfs/base/file
	if _, err := writeRootfsFile(rootfs, file, 0647); err != nil {
	return "", err
	}

	return path, nil
	},
	expectedMode: 0647,
	},
	}

	for _, test := range tests {
	tmpdir, err := ioutil.TempDir("", "nsenter-get-mode-")
	if err != nil {
	t.Error(err)
	continue
	}
	defer os.RemoveAll(tmpdir)

	testBase := filepath.Join(tmpdir, "base")
	if err := os.Mkdir(testBase, 0755); err != nil {
	t.Error(err)
	continue
	}

	mounter, rootfs, _, err := newFakeNsenterMounter(tmpdir, t)
	if err != nil {
	t.Error(err)
	continue
	}

	path, err := test.prepare(testBase, rootfs)
	if err != nil {
	t.Error(err)
	continue
	}

	mode, err := mounter.GetMode(path)
	if err != nil && !test.expectError {
	t.Errorf("Test %q: unexpected error: %s", test.name, err)
	}
	if err == nil && test.expectError {
	t.Errorf("Test %q: expected error, got none", test.name)
	}

	if mode != test.expectedMode {
	t.Errorf("Test %q: expected return value %v, got %v", test.name, test.expectedMode, mode)
	}
	}
	}

	func writeRootfsFile(rootfs, path string, mode os.FileMode) (string, error) {
	fullPath := filepath.Join(rootfs, path)
	dir := filepath.Dir(fullPath)
	if err := os.MkdirAll(dir, 0755); err != nil {
	return "", err
	}
	if err := ioutil.WriteFile(fullPath, []byte{}, mode); err != nil {
	return "", err
	}
	// Use chmod, io.WriteFile is affected by umask
	if err := os.Chmod(fullPath, mode); err != nil {
	return "", err
	}
	return fullPath, nil
	}

	func TestNsenterSafeMakeDir(t *testing.T) {
	tests := []struct {
	name string
	prepare func(base, rootfs, varlib string) (expectedDir string, err error)
	subdir string
	expectError bool
	// If true, "base" directory for SafeMakeDir will be /var/lib/kubelet
	baseIsVarLib bool
	}{
	{
	name: "simple directory",
	// evaluated in base
	subdir: "some/subdirectory/structure",
	prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
	// expected to be created in /roots/
	expectedDir = filepath.Join(rootfs, base, "some/subdirectory/structure")
	return expectedDir, nil
	},
	},
	{
	name: "simple existing directory",
	// evaluated in base
	subdir: "some/subdirectory/structure",
	prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
	// On the host: directory exists
	hostPath := filepath.Join(base, "some/subdirectory/structure")
	if err := os.MkdirAll(hostPath, 0755); err != nil {
	return "", err
	}
	// In rootfs: directory exists
	kubeletPath := filepath.Join(rootfs, hostPath)
	if err := os.MkdirAll(kubeletPath, 0755); err != nil {
	return "", err
	}
	// expected to be created in /roots/
	expectedDir = kubeletPath
	return expectedDir, nil
	},
	},
	{
	name: "absolute symlink into safe place",
	// evaluated in base
	subdir: "some/subdirectory/structure",
	prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
	// On the host: /base/other/subdirectory exists, /base/some is link to /base/other
	hostPath := filepath.Join(base, "other/subdirectory")
	if err := os.MkdirAll(hostPath, 0755); err != nil {
	return "", err
	}
	somePath := filepath.Join(base, "some")
	otherPath := filepath.Join(base, "other")
	if err := os.Symlink(otherPath, somePath); err != nil {
	return "", err
	}

	// In rootfs: /base/other/subdirectory exists
	kubeletPath := filepath.Join(rootfs, hostPath)
	if err := os.MkdirAll(kubeletPath, 0755); err != nil {
	return "", err
	}
	// expected 'structure' to be created
	expectedDir = filepath.Join(rootfs, hostPath, "structure")
	return expectedDir, nil
	},
	},
	{
	name: "relative symlink into safe place",
	// evaluated in base
	subdir: "some/subdirectory/structure",
	prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
	// On the host: /base/other/subdirectory exists, /base/some is link to other
	hostPath := filepath.Join(base, "other/subdirectory")
	if err := os.MkdirAll(hostPath, 0755); err != nil {
	return "", err
	}
	somePath := filepath.Join(base, "some")
	if err := os.Symlink("other", somePath); err != nil {
	return "", err
	}

	// In rootfs: /base/other/subdirectory exists
	kubeletPath := filepath.Join(rootfs, hostPath)
	if err := os.MkdirAll(kubeletPath, 0755); err != nil {
	return "", err
	}
	// expected 'structure' to be created
	expectedDir = filepath.Join(rootfs, hostPath, "structure")
	return expectedDir, nil
	},
	},
	{
	name: "symlink into unsafe place",
	// evaluated in base
	subdir: "some/subdirectory/structure",
	prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
	// On the host: /base/some is link to /bin/other
	somePath := filepath.Join(base, "some")
	if err := os.Symlink("/bin", somePath); err != nil {
	return "", err
	}
	return "", nil
	},
	expectError: true,
	},
	{
	name: "simple directory in /var/lib/kubelet",
	// evaluated in varlib
	subdir: "some/subdirectory/structure",
	baseIsVarLib: true,
	prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
	// expected to be created in /base/var/lib/kubelet, not in /rootfs!
	expectedDir = filepath.Join(varlib, "some/subdirectory/structure")
	return expectedDir, nil
	},
	},
	{
	name: "safe symlink in /var/lib/kubelet",
	// evaluated in varlib
	subdir: "some/subdirectory/structure",
	baseIsVarLib: true,
	prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
	// On the host: /varlib/kubelet/other/subdirectory exists, /varlib/some is link to other
	hostPath := filepath.Join(varlib, "other/subdirectory")
	if err := os.MkdirAll(hostPath, 0755); err != nil {
	return "", err
	}
	somePath := filepath.Join(varlib, "some")
	if err := os.Symlink("other", somePath); err != nil {
	return "", err
	}

	// expected to be created in /base/var/lib/kubelet, not in /rootfs!
	expectedDir = filepath.Join(varlib, "other/subdirectory/structure")
	return expectedDir, nil
	},
	},
	{
	name: "unsafe symlink in /var/lib/kubelet",
	// evaluated in varlib
	subdir: "some/subdirectory/structure",
	baseIsVarLib: true,
	prepare: func(base, rootfs, varlib string) (expectedDir string, err error) {
	// On the host: /varlib/some is link to /bin
	somePath := filepath.Join(varlib, "some")
	if err := os.Symlink("/bin", somePath); err != nil {
	return "", err
	}

	return "", nil
	},
	expectError: true,
	},
	}
	for _, test := range tests {
	tmpdir, err := ioutil.TempDir("", "nsenter-get-mode-")
	if err != nil {
	t.Error(err)
	continue
	}
	defer os.RemoveAll(tmpdir)

	mounter, rootfs, varlib, err := newFakeNsenterMounter(tmpdir, t)
	if err != nil {
	t.Error(err)
	continue
	}
	// Prepare base directory for the test
	testBase := filepath.Join(tmpdir, "base")
	if err := os.Mkdir(testBase, 0755); err != nil {
	t.Error(err)
	continue
	}
	// Prepare base directory also in /rootfs
	rootfsBase := filepath.Join(rootfs, testBase)
	if err := os.MkdirAll(rootfsBase, 0755); err != nil {
	t.Error(err)
	continue
	}

	expectedDir := ""
	if test.prepare != nil {
	expectedDir, err = test.prepare(testBase, rootfs, varlib)
	if err != nil {
	t.Error(err)
	continue
	}
	}

	if test.baseIsVarLib {
	// use /var/lib/kubelet as the test base so we can test creating
	// subdirs there directly in /var/lib/kubenet and not in
	// /rootfs/var/lib/kubelet
	testBase = varlib
	}

	err = mounter.SafeMakeDir(test.subdir, testBase, 0755)
	if err != nil && !test.expectError {
	t.Errorf("Test %q: unexpected error: %s", test.name, err)
	}
	if test.expectError {
	if err == nil {
	t.Errorf("Test %q: expected error, got none", test.name)
	} else {
	if !strings.Contains(err.Error(), "is outside of allowed base") {
	t.Errorf("Test %q: expected error to contain \"is outside of allowed base\", got this one instead: %s", test.name, err)
	}
	}
	}

	if expectedDir != "" {
	_, err := os.Stat(expectedDir)
	if err != nil {
	t.Errorf("Test %q: expected %q to exist, got error: %s", test.name, expectedDir, err)
	}
	}
	}
	}