| /* |
| Copyright 2016 The Kubernetes Authors. |
| |
| Licensed under the Apache License, Version 2.0 (the "License"); |
| you may not use this file except in compliance with the License. |
| You may obtain a copy of the License at |
| |
| http://www.apache.org/licenses/LICENSE-2.0 |
| |
| Unless required by applicable law or agreed to in writing, software |
| distributed under the License is distributed on an "AS IS" BASIS, |
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| See the License for the specific language governing permissions and |
| limitations under the License. |
| */ |
| |
| package validation |
| |
| import ( |
| "strconv" |
| "strings" |
| "testing" |
| |
| "github.com/davecgh/go-spew/spew" |
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
| "k8s.io/apimachinery/pkg/runtime" |
| "k8s.io/apimachinery/pkg/util/intstr" |
| "k8s.io/apimachinery/pkg/util/validation/field" |
| "k8s.io/kubernetes/pkg/apis/apps" |
| api "k8s.io/kubernetes/pkg/apis/core" |
| ) |
| |
| func TestValidateStatefulSet(t *testing.T) { |
| validLabels := map[string]string{"a": "b"} |
| validPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent"}}, |
| }, |
| }, |
| } |
| |
| invalidLabels := map[string]string{"NoUppercaseOrSpecialCharsLike=Equals": "b"} |
| invalidPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: invalidLabels, |
| }, |
| }, |
| } |
| |
| invalidTime := int64(60) |
| invalidPodTemplate2 := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: map[string]string{"foo": "bar"}, |
| }, |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyOnFailure, |
| DNSPolicy: api.DNSClusterFirst, |
| ActiveDeadlineSeconds: &invalidTime, |
| }, |
| }, |
| } |
| |
| successCases := []apps.StatefulSet{ |
| { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.ParallelPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.OnDeleteStatefulSetStrategyType}, |
| }, |
| }, |
| { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| Replicas: 3, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{ |
| Type: apps.RollingUpdateStatefulSetStrategyType, |
| RollingUpdate: func() *apps.RollingUpdateStatefulSetStrategy { |
| return &apps.RollingUpdateStatefulSetStrategy{Partition: 2} |
| }()}, |
| }, |
| }, |
| } |
| |
| for i, successCase := range successCases { |
| t.Run("success case "+strconv.Itoa(i), func(t *testing.T) { |
| if errs := ValidateStatefulSet(&successCase); len(errs) != 0 { |
| t.Errorf("expected success: %v", errs) |
| } |
| }) |
| } |
| |
| errorCases := map[string]apps.StatefulSet{ |
| "zero-length ID": { |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "missing-namespace": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123"}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "empty selector": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "selector_doesnt_match": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "invalid manifest": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "negative_replicas": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Replicas: -1, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "invalid_label": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| Labels: map[string]string{ |
| "NoUppercaseOrSpecialCharsLike=Equals": "bar", |
| }, |
| }, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "invalid_label 2": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| Labels: map[string]string{ |
| "NoUppercaseOrSpecialCharsLike=Equals": "bar", |
| }, |
| }, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Template: invalidPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "invalid_annotation": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| Annotations: map[string]string{ |
| "NoUppercaseOrSpecialCharsLike=Equals": "bar", |
| }, |
| }, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "invalid restart policy 1": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| }, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyOnFailure, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "ctr", Image: "image", ImagePullPolicy: "IfNotPresent"}}, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| }, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "invalid restart policy 2": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| }, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyNever, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "ctr", Image: "image", ImagePullPolicy: "IfNotPresent"}}, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| }, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "invalid update strategy": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| Replicas: 3, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: "foo"}, |
| }, |
| }, |
| "empty update strategy": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| Replicas: 3, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: ""}, |
| }, |
| }, |
| "invalid rolling update": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| Replicas: 3, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.OnDeleteStatefulSetStrategyType, |
| RollingUpdate: func() *apps.RollingUpdateStatefulSetStrategy { |
| return &apps.RollingUpdateStatefulSetStrategy{Partition: 1} |
| }()}, |
| }, |
| }, |
| "negative parition": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| Replicas: 3, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType, |
| RollingUpdate: func() *apps.RollingUpdateStatefulSetStrategy { |
| return &apps.RollingUpdateStatefulSetStrategy{Partition: -1} |
| }()}, |
| }, |
| }, |
| "empty pod management policy": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: "", |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| Replicas: 3, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "invalid pod management policy": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: "foo", |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| Replicas: 3, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| "set active deadline seconds": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: "foo", |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: invalidPodTemplate2.Template, |
| Replicas: 3, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| } |
| |
| for k, v := range errorCases { |
| t.Run(k, func(t *testing.T) { |
| errs := ValidateStatefulSet(&v) |
| if len(errs) == 0 { |
| t.Errorf("expected failure for %s", k) |
| } |
| |
| for i := range errs { |
| field := errs[i].Field |
| if !strings.HasPrefix(field, "spec.template.") && |
| field != "metadata.name" && |
| field != "metadata.namespace" && |
| field != "spec.selector" && |
| field != "spec.template" && |
| field != "GCEPersistentDisk.ReadOnly" && |
| field != "spec.replicas" && |
| field != "spec.template.labels" && |
| field != "metadata.annotations" && |
| field != "metadata.labels" && |
| field != "status.replicas" && |
| field != "spec.updateStrategy" && |
| field != "spec.updateStrategy.rollingUpdate" && |
| field != "spec.updateStrategy.rollingUpdate.partition" && |
| field != "spec.podManagementPolicy" && |
| field != "spec.template.spec.activeDeadlineSeconds" { |
| t.Errorf("%s: missing prefix for: %v", k, errs[i]) |
| } |
| } |
| }) |
| } |
| } |
| |
| func TestValidateStatefulSetStatus(t *testing.T) { |
| observedGenerationMinusOne := int64(-1) |
| collisionCountMinusOne := int32(-1) |
| tests := []struct { |
| name string |
| replicas int32 |
| readyReplicas int32 |
| currentReplicas int32 |
| updatedReplicas int32 |
| observedGeneration *int64 |
| collisionCount *int32 |
| expectedErr bool |
| }{ |
| { |
| name: "valid status", |
| replicas: 3, |
| readyReplicas: 3, |
| currentReplicas: 2, |
| updatedReplicas: 1, |
| expectedErr: false, |
| }, |
| { |
| name: "invalid replicas", |
| replicas: -1, |
| readyReplicas: 3, |
| currentReplicas: 2, |
| updatedReplicas: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid readyReplicas", |
| replicas: 3, |
| readyReplicas: -1, |
| currentReplicas: 2, |
| updatedReplicas: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid currentReplicas", |
| replicas: 3, |
| readyReplicas: 3, |
| currentReplicas: -1, |
| updatedReplicas: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid updatedReplicas", |
| replicas: 3, |
| readyReplicas: 3, |
| currentReplicas: 2, |
| updatedReplicas: -1, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid observedGeneration", |
| replicas: 3, |
| readyReplicas: 3, |
| currentReplicas: 2, |
| updatedReplicas: 1, |
| observedGeneration: &observedGenerationMinusOne, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid collisionCount", |
| replicas: 3, |
| readyReplicas: 3, |
| currentReplicas: 2, |
| updatedReplicas: 1, |
| collisionCount: &collisionCountMinusOne, |
| expectedErr: true, |
| }, |
| { |
| name: "readyReplicas greater than replicas", |
| replicas: 3, |
| readyReplicas: 4, |
| currentReplicas: 2, |
| updatedReplicas: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "currentReplicas greater than replicas", |
| replicas: 3, |
| readyReplicas: 3, |
| currentReplicas: 4, |
| updatedReplicas: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "updatedReplicas greater than replicas", |
| replicas: 3, |
| readyReplicas: 3, |
| currentReplicas: 2, |
| updatedReplicas: 4, |
| expectedErr: true, |
| }, |
| } |
| |
| for _, test := range tests { |
| t.Run(test.name, func(t *testing.T) { |
| status := apps.StatefulSetStatus{ |
| Replicas: test.replicas, |
| ReadyReplicas: test.readyReplicas, |
| CurrentReplicas: test.currentReplicas, |
| UpdatedReplicas: test.updatedReplicas, |
| ObservedGeneration: test.observedGeneration, |
| CollisionCount: test.collisionCount, |
| } |
| |
| errs := ValidateStatefulSetStatus(&status, field.NewPath("status")) |
| if hasErr := len(errs) > 0; hasErr != test.expectedErr { |
| t.Errorf("%s: expected error: %t, got error: %t\nerrors: %s", test.name, test.expectedErr, hasErr, errs.ToAggregate().Error()) |
| } |
| }) |
| } |
| } |
| |
| func TestValidateStatefulSetUpdate(t *testing.T) { |
| validLabels := map[string]string{"a": "b"} |
| validPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent"}}, |
| }, |
| }, |
| } |
| |
| addContainersValidTemplate := validPodTemplate.DeepCopy() |
| addContainersValidTemplate.Template.Spec.Containers = append(addContainersValidTemplate.Template.Spec.Containers, |
| api.Container{Name: "def", Image: "image2", ImagePullPolicy: "IfNotPresent"}) |
| if len(addContainersValidTemplate.Template.Spec.Containers) != len(validPodTemplate.Template.Spec.Containers)+1 { |
| t.Errorf("failure during test setup: template %v should have more containers than template %v", addContainersValidTemplate, validPodTemplate) |
| } |
| |
| readWriteVolumePodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent"}}, |
| Volumes: []api.Volume{{Name: "gcepd", VolumeSource: api.VolumeSource{GCEPersistentDisk: &api.GCEPersistentDiskVolumeSource{PDName: "my-PD", FSType: "ext4", Partition: 1, ReadOnly: false}}}}, |
| }, |
| }, |
| } |
| invalidLabels := map[string]string{"NoUppercaseOrSpecialCharsLike=Equals": "b"} |
| invalidPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: invalidLabels, |
| }, |
| }, |
| } |
| |
| type psUpdateTest struct { |
| old apps.StatefulSet |
| update apps.StatefulSet |
| } |
| successCases := []psUpdateTest{ |
| { |
| old: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| update: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Replicas: 3, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| }, |
| { |
| old: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| update: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: addContainersValidTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| }, |
| { |
| old: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: addContainersValidTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| update: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| }, |
| } |
| |
| for i, successCase := range successCases { |
| t.Run("success case "+strconv.Itoa(i), func(t *testing.T) { |
| successCase.old.ObjectMeta.ResourceVersion = "1" |
| successCase.update.ObjectMeta.ResourceVersion = "1" |
| if errs := ValidateStatefulSetUpdate(&successCase.update, &successCase.old); len(errs) != 0 { |
| t.Errorf("expected success: %v", errs) |
| } |
| }) |
| } |
| |
| errorCases := map[string]psUpdateTest{ |
| "more than one read/write": { |
| old: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| update: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Replicas: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: readWriteVolumePodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| }, |
| "empty pod creation policy": { |
| old: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| update: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| Replicas: 3, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| }, |
| "invalid pod creation policy": { |
| old: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| update: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.PodManagementPolicyType("Other"), |
| Replicas: 3, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| }, |
| "invalid selector": { |
| old: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| update: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Replicas: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: invalidLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| }, |
| "invalid pod": { |
| old: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| update: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| Replicas: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: invalidPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| }, |
| "negative replicas": { |
| old: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| update: apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| PodManagementPolicy: apps.OrderedReadyPodManagement, |
| Replicas: -1, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.StatefulSetUpdateStrategy{Type: apps.RollingUpdateStatefulSetStrategyType}, |
| }, |
| }, |
| }, |
| } |
| |
| for testName, errorCase := range errorCases { |
| t.Run(testName, func(t *testing.T) { |
| if errs := ValidateStatefulSetUpdate(&errorCase.update, &errorCase.old); len(errs) == 0 { |
| t.Errorf("expected failure: %s", testName) |
| } |
| }) |
| } |
| } |
| |
| func TestValidateControllerRevision(t *testing.T) { |
| newControllerRevision := func(name, namespace string, data runtime.Object, revision int64) apps.ControllerRevision { |
| return apps.ControllerRevision{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: name, |
| Namespace: namespace, |
| }, |
| Data: data, |
| Revision: revision, |
| } |
| } |
| |
| ss := apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}}, |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: map[string]string{"foo": "bar"}, |
| }, |
| }, |
| }, |
| } |
| |
| var ( |
| valid = newControllerRevision("validname", "validns", &ss, 0) |
| badRevision = newControllerRevision("validname", "validns", &ss, -1) |
| emptyName = newControllerRevision("", "validns", &ss, 0) |
| invalidName = newControllerRevision("NoUppercaseOrSpecialCharsLike=Equals", "validns", &ss, 0) |
| emptyNs = newControllerRevision("validname", "", &ss, 100) |
| invalidNs = newControllerRevision("validname", "NoUppercaseOrSpecialCharsLike=Equals", &ss, 100) |
| nilData = newControllerRevision("validname", "NoUppercaseOrSpecialCharsLike=Equals", nil, 100) |
| ) |
| |
| tests := map[string]struct { |
| history apps.ControllerRevision |
| isValid bool |
| }{ |
| "valid": {valid, true}, |
| "negative revision": {badRevision, false}, |
| "empty name": {emptyName, false}, |
| "invalid name": {invalidName, false}, |
| "empty namespace": {emptyNs, false}, |
| "invalid namespace": {invalidNs, false}, |
| "nil data": {nilData, false}, |
| } |
| |
| for name, tc := range tests { |
| t.Run(name, func(t *testing.T) { |
| errs := ValidateControllerRevision(&tc.history) |
| if tc.isValid && len(errs) > 0 { |
| t.Errorf("%v: unexpected error: %v", name, errs) |
| } |
| if !tc.isValid && len(errs) == 0 { |
| t.Errorf("%v: unexpected non-error", name) |
| } |
| }) |
| } |
| } |
| |
| func TestValidateControllerRevisionUpdate(t *testing.T) { |
| newControllerRevision := func(version, name, namespace string, data runtime.Object, revision int64) apps.ControllerRevision { |
| return apps.ControllerRevision{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: name, |
| Namespace: namespace, |
| ResourceVersion: version, |
| }, |
| Data: data, |
| Revision: revision, |
| } |
| } |
| |
| ss := apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}}, |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: map[string]string{"foo": "bar"}, |
| }, |
| }, |
| }, |
| } |
| modifiedss := apps.StatefulSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "cdf", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.StatefulSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}}, |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: map[string]string{"foo": "bar"}, |
| }, |
| }, |
| }, |
| } |
| |
| var ( |
| valid = newControllerRevision("1", "validname", "validns", &ss, 0) |
| noVersion = newControllerRevision("", "validname", "validns", &ss, 0) |
| changedData = newControllerRevision("1", "validname", "validns", &modifiedss, 0) |
| changedRevision = newControllerRevision("1", "validname", "validns", &ss, 1) |
| ) |
| |
| cases := []struct { |
| name string |
| newHistory apps.ControllerRevision |
| oldHistory apps.ControllerRevision |
| isValid bool |
| }{ |
| { |
| name: "valid", |
| newHistory: valid, |
| oldHistory: valid, |
| isValid: true, |
| }, |
| { |
| name: "invalid", |
| newHistory: noVersion, |
| oldHistory: valid, |
| isValid: false, |
| }, |
| { |
| name: "changed data", |
| newHistory: changedData, |
| oldHistory: valid, |
| isValid: false, |
| }, |
| { |
| name: "changed revision", |
| newHistory: changedRevision, |
| oldHistory: valid, |
| isValid: true, |
| }, |
| } |
| |
| for _, tc := range cases { |
| t.Run(tc.name, func(t *testing.T) { |
| errs := ValidateControllerRevisionUpdate(&tc.newHistory, &tc.oldHistory) |
| if tc.isValid && len(errs) > 0 { |
| t.Errorf("%v: unexpected error: %v", tc.name, errs) |
| } |
| if !tc.isValid && len(errs) == 0 { |
| t.Errorf("%v: unexpected non-error", tc.name) |
| } |
| }) |
| } |
| } |
| |
| func TestValidateDaemonSetStatusUpdate(t *testing.T) { |
| type dsUpdateTest struct { |
| old apps.DaemonSet |
| update apps.DaemonSet |
| } |
| |
| successCases := []dsUpdateTest{ |
| { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 2, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 1, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| }, |
| } |
| |
| for _, successCase := range successCases { |
| successCase.old.ObjectMeta.ResourceVersion = "1" |
| successCase.update.ObjectMeta.ResourceVersion = "1" |
| if errs := ValidateDaemonSetStatusUpdate(&successCase.update, &successCase.old); len(errs) != 0 { |
| t.Errorf("expected success: %v", errs) |
| } |
| } |
| errorCases := map[string]dsUpdateTest{ |
| "negative values": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 2, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: -1, |
| NumberMisscheduled: -1, |
| DesiredNumberScheduled: -3, |
| NumberReady: -1, |
| ObservedGeneration: -3, |
| UpdatedNumberScheduled: -1, |
| NumberAvailable: -1, |
| NumberUnavailable: -2, |
| }, |
| }, |
| }, |
| "negative CurrentNumberScheduled": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 2, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: -1, |
| NumberMisscheduled: 1, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| }, |
| "negative NumberMisscheduled": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 2, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: -1, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| }, |
| "negative DesiredNumberScheduled": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 2, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 1, |
| DesiredNumberScheduled: -3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| }, |
| "negative NumberReady": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 2, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 1, |
| DesiredNumberScheduled: 3, |
| NumberReady: -1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| }, |
| "negative ObservedGeneration": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 2, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 1, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: -3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| }, |
| "negative UpdatedNumberScheduled": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 2, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 1, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: -1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| }, |
| "negative NumberAvailable": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 2, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 1, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: -1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| }, |
| "negative NumberUnavailable": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 2, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: 2, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| ResourceVersion: "10", |
| }, |
| Status: apps.DaemonSetStatus{ |
| CurrentNumberScheduled: 1, |
| NumberMisscheduled: 1, |
| DesiredNumberScheduled: 3, |
| NumberReady: 1, |
| ObservedGeneration: 3, |
| UpdatedNumberScheduled: 1, |
| NumberAvailable: 1, |
| NumberUnavailable: -2, |
| }, |
| }, |
| }, |
| } |
| |
| for testName, errorCase := range errorCases { |
| if errs := ValidateDaemonSetStatusUpdate(&errorCase.update, &errorCase.old); len(errs) == 0 { |
| t.Errorf("expected failure: %s", testName) |
| } |
| } |
| } |
| |
| func TestValidateDaemonSetUpdate(t *testing.T) { |
| validSelector := map[string]string{"a": "b"} |
| validSelector2 := map[string]string{"c": "d"} |
| invalidSelector := map[string]string{"NoUppercaseOrSpecialCharsLike=Equals": "b"} |
| |
| validPodSpecAbc := api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| } |
| validPodSpecDef := api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "def", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| } |
| validPodSpecNodeSelector := api.PodSpec{ |
| NodeSelector: validSelector, |
| NodeName: "xyz", |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| } |
| validPodSpecVolume := api.PodSpec{ |
| Volumes: []api.Volume{{Name: "gcepd", VolumeSource: api.VolumeSource{GCEPersistentDisk: &api.GCEPersistentDiskVolumeSource{PDName: "my-PD", FSType: "ext4", Partition: 1, ReadOnly: false}}}}, |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| } |
| |
| validPodTemplateAbc := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validSelector, |
| }, |
| Spec: validPodSpecAbc, |
| }, |
| } |
| validPodTemplateAbcSemanticallyEqual := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validSelector, |
| }, |
| Spec: validPodSpecAbc, |
| }, |
| } |
| validPodTemplateAbcSemanticallyEqual.Template.Spec.ImagePullSecrets = []api.LocalObjectReference{} |
| validPodTemplateNodeSelector := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validSelector, |
| }, |
| Spec: validPodSpecNodeSelector, |
| }, |
| } |
| validPodTemplateAbc2 := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validSelector2, |
| }, |
| Spec: validPodSpecAbc, |
| }, |
| } |
| validPodTemplateDef := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validSelector2, |
| }, |
| Spec: validPodSpecDef, |
| }, |
| } |
| invalidPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| // no containers specified |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validSelector, |
| }, |
| }, |
| } |
| readWriteVolumePodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validSelector, |
| }, |
| Spec: validPodSpecVolume, |
| }, |
| } |
| |
| type dsUpdateTest struct { |
| old apps.DaemonSet |
| update apps.DaemonSet |
| expectedErrNum int |
| } |
| successCases := map[string]dsUpdateTest{ |
| "no change": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| }, |
| "change template and selector": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 2, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector2}, |
| TemplateGeneration: 3, |
| Template: validPodTemplateAbc2.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| }, |
| "change template": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 3, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 4, |
| Template: validPodTemplateNodeSelector.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| }, |
| "change container image name": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector2}, |
| TemplateGeneration: 2, |
| Template: validPodTemplateDef.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| }, |
| "change update strategy": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 4, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 4, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.RollingUpdateDaemonSetStrategyType, |
| RollingUpdate: &apps.RollingUpdateDaemonSet{ |
| MaxUnavailable: intstr.FromInt(1), |
| }, |
| }, |
| }, |
| }, |
| }, |
| "unchanged templateGeneration upon semantically equal template update": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 4, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 4, |
| Template: validPodTemplateAbcSemanticallyEqual.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.RollingUpdateDaemonSetStrategyType, |
| RollingUpdate: &apps.RollingUpdateDaemonSet{ |
| MaxUnavailable: intstr.FromInt(1), |
| }, |
| }, |
| }, |
| }, |
| }, |
| } |
| for testName, successCase := range successCases { |
| // ResourceVersion is required for updates. |
| successCase.old.ObjectMeta.ResourceVersion = "1" |
| successCase.update.ObjectMeta.ResourceVersion = "2" |
| // Check test setup |
| if successCase.expectedErrNum > 0 { |
| t.Errorf("%q has incorrect test setup with expectedErrNum %d, expected no error", testName, successCase.expectedErrNum) |
| } |
| if len(successCase.old.ObjectMeta.ResourceVersion) == 0 || len(successCase.update.ObjectMeta.ResourceVersion) == 0 { |
| t.Errorf("%q has incorrect test setup with no resource version set", testName) |
| } |
| if errs := ValidateDaemonSetUpdate(&successCase.update, &successCase.old); len(errs) != 0 { |
| t.Errorf("%q expected no error, but got: %v", testName, errs) |
| } |
| } |
| errorCases := map[string]dsUpdateTest{ |
| "change daemon name": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| expectedErrNum: 1, |
| }, |
| "invalid selector": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: invalidSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| expectedErrNum: 1, |
| }, |
| "invalid pod": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 2, |
| Template: invalidPodTemplate.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| expectedErrNum: 1, |
| }, |
| "invalid read-write volume": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 2, |
| Template: readWriteVolumePodTemplate.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| expectedErrNum: 1, |
| }, |
| "invalid update strategy": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: 1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: "Random", |
| }, |
| }, |
| }, |
| expectedErrNum: 1, |
| }, |
| "negative templateGeneration": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: -1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| TemplateGeneration: -1, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| expectedErrNum: 1, |
| }, |
| "decreased templateGeneration": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| TemplateGeneration: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| TemplateGeneration: 1, |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| expectedErrNum: 1, |
| }, |
| "unchanged templateGeneration upon template update": { |
| old: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| TemplateGeneration: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: validPodTemplateAbc.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| update: apps.DaemonSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| TemplateGeneration: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector2}, |
| Template: validPodTemplateAbc2.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| expectedErrNum: 1, |
| }, |
| } |
| for testName, errorCase := range errorCases { |
| // ResourceVersion is required for updates. |
| errorCase.old.ObjectMeta.ResourceVersion = "1" |
| errorCase.update.ObjectMeta.ResourceVersion = "2" |
| // Check test setup |
| if errorCase.expectedErrNum <= 0 { |
| t.Errorf("%q has incorrect test setup with expectedErrNum %d, expected at least one error", testName, errorCase.expectedErrNum) |
| } |
| if len(errorCase.old.ObjectMeta.ResourceVersion) == 0 || len(errorCase.update.ObjectMeta.ResourceVersion) == 0 { |
| t.Errorf("%q has incorrect test setup with no resource version set", testName) |
| } |
| // Run the tests |
| if errs := ValidateDaemonSetUpdate(&errorCase.update, &errorCase.old); len(errs) != errorCase.expectedErrNum { |
| t.Errorf("%q expected %d errors, but got %d error: %v", testName, errorCase.expectedErrNum, len(errs), errs) |
| } else { |
| t.Logf("(PASS) %q got errors %v", testName, errs) |
| } |
| } |
| } |
| |
| func TestValidateDaemonSet(t *testing.T) { |
| validSelector := map[string]string{"a": "b"} |
| validPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validSelector, |
| }, |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| }, |
| }, |
| } |
| invalidSelector := map[string]string{"NoUppercaseOrSpecialCharsLike=Equals": "b"} |
| invalidPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: invalidSelector, |
| }, |
| }, |
| } |
| successCases := []apps.DaemonSet{ |
| { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: validPodTemplate.Template, |
| UpdateStrategy: apps.DaemonSetUpdateStrategy{ |
| Type: apps.OnDeleteDaemonSetStrategyType, |
| }, |
| }, |
| }, |
| } |
| for _, successCase := range successCases { |
| if errs := ValidateDaemonSet(&successCase); len(errs) != 0 { |
| t.Errorf("expected success: %v", errs) |
| } |
| } |
| |
| errorCases := map[string]apps.DaemonSet{ |
| "zero-length ID": { |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "missing-namespace": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123"}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "nil selector": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "empty selector": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "selector_doesnt_match": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "invalid template": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| }, |
| }, |
| "invalid_label": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| Labels: map[string]string{ |
| "NoUppercaseOrSpecialCharsLike=Equals": "bar", |
| }, |
| }, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "invalid_label 2": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| Labels: map[string]string{ |
| "NoUppercaseOrSpecialCharsLike=Equals": "bar", |
| }, |
| }, |
| Spec: apps.DaemonSetSpec{ |
| Template: invalidPodTemplate.Template, |
| }, |
| }, |
| "invalid_annotation": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| Annotations: map[string]string{ |
| "NoUppercaseOrSpecialCharsLike=Equals": "bar", |
| }, |
| }, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "invalid restart policy 1": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| }, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyOnFailure, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "ctr", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validSelector, |
| }, |
| }, |
| }, |
| }, |
| "invalid restart policy 2": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| }, |
| Spec: apps.DaemonSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validSelector}, |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyNever, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "ctr", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validSelector, |
| }, |
| }, |
| }, |
| }, |
| } |
| for k, v := range errorCases { |
| errs := ValidateDaemonSet(&v) |
| if len(errs) == 0 { |
| t.Errorf("expected failure for %s", k) |
| } |
| for i := range errs { |
| field := errs[i].Field |
| if !strings.HasPrefix(field, "spec.template.") && |
| !strings.HasPrefix(field, "spec.updateStrategy") && |
| field != "metadata.name" && |
| field != "metadata.namespace" && |
| field != "spec.selector" && |
| field != "spec.template" && |
| field != "GCEPersistentDisk.ReadOnly" && |
| field != "spec.template.labels" && |
| field != "metadata.annotations" && |
| field != "metadata.labels" { |
| t.Errorf("%s: missing prefix for: %v", k, errs[i]) |
| } |
| } |
| } |
| } |
| |
| func validDeployment() *apps.Deployment { |
| return &apps.Deployment{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| }, |
| Spec: apps.DeploymentSpec{ |
| Selector: &metav1.LabelSelector{ |
| MatchLabels: map[string]string{ |
| "name": "abc", |
| }, |
| }, |
| Strategy: apps.DeploymentStrategy{ |
| Type: apps.RollingUpdateDeploymentStrategyType, |
| RollingUpdate: &apps.RollingUpdateDeployment{ |
| MaxSurge: intstr.FromInt(1), |
| MaxUnavailable: intstr.FromInt(1), |
| }, |
| }, |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc", |
| Namespace: metav1.NamespaceDefault, |
| Labels: map[string]string{ |
| "name": "abc", |
| }, |
| }, |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSDefault, |
| Containers: []api.Container{ |
| { |
| Name: "nginx", |
| Image: "image", |
| ImagePullPolicy: api.PullNever, |
| TerminationMessagePolicy: api.TerminationMessageReadFile, |
| }, |
| }, |
| }, |
| }, |
| RollbackTo: &apps.RollbackConfig{ |
| Revision: 1, |
| }, |
| }, |
| } |
| } |
| |
| func TestValidateDeployment(t *testing.T) { |
| successCases := []*apps.Deployment{ |
| validDeployment(), |
| } |
| for _, successCase := range successCases { |
| if errs := ValidateDeployment(successCase); len(errs) != 0 { |
| t.Errorf("expected success: %v", errs) |
| } |
| } |
| |
| errorCases := map[string]*apps.Deployment{} |
| errorCases["metadata.name: Required value"] = &apps.Deployment{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Namespace: metav1.NamespaceDefault, |
| }, |
| } |
| // selector should match the labels in pod template. |
| invalidSelectorDeployment := validDeployment() |
| invalidSelectorDeployment.Spec.Selector = &metav1.LabelSelector{ |
| MatchLabels: map[string]string{ |
| "name": "def", |
| }, |
| } |
| errorCases["`selector` does not match template `labels`"] = invalidSelectorDeployment |
| |
| // RestartPolicy should be always. |
| invalidRestartPolicyDeployment := validDeployment() |
| invalidRestartPolicyDeployment.Spec.Template.Spec.RestartPolicy = api.RestartPolicyNever |
| errorCases["Unsupported value: \"Never\""] = invalidRestartPolicyDeployment |
| |
| // must have valid strategy type |
| invalidStrategyDeployment := validDeployment() |
| invalidStrategyDeployment.Spec.Strategy.Type = apps.DeploymentStrategyType("randomType") |
| errorCases[`supported values: "Recreate", "RollingUpdate"`] = invalidStrategyDeployment |
| |
| // rollingUpdate should be nil for recreate. |
| invalidRecreateDeployment := validDeployment() |
| invalidRecreateDeployment.Spec.Strategy = apps.DeploymentStrategy{ |
| Type: apps.RecreateDeploymentStrategyType, |
| RollingUpdate: &apps.RollingUpdateDeployment{}, |
| } |
| errorCases["may not be specified when strategy `type` is 'Recreate'"] = invalidRecreateDeployment |
| |
| // MaxSurge should be in the form of 20%. |
| invalidMaxSurgeDeployment := validDeployment() |
| invalidMaxSurgeDeployment.Spec.Strategy = apps.DeploymentStrategy{ |
| Type: apps.RollingUpdateDeploymentStrategyType, |
| RollingUpdate: &apps.RollingUpdateDeployment{ |
| MaxSurge: intstr.FromString("20Percent"), |
| }, |
| } |
| errorCases["a valid percent string must be"] = invalidMaxSurgeDeployment |
| |
| // MaxSurge and MaxUnavailable cannot both be zero. |
| invalidRollingUpdateDeployment := validDeployment() |
| invalidRollingUpdateDeployment.Spec.Strategy = apps.DeploymentStrategy{ |
| Type: apps.RollingUpdateDeploymentStrategyType, |
| RollingUpdate: &apps.RollingUpdateDeployment{ |
| MaxSurge: intstr.FromString("0%"), |
| MaxUnavailable: intstr.FromInt(0), |
| }, |
| } |
| errorCases["may not be 0 when `maxSurge` is 0"] = invalidRollingUpdateDeployment |
| |
| // MaxUnavailable should not be more than 100%. |
| invalidMaxUnavailableDeployment := validDeployment() |
| invalidMaxUnavailableDeployment.Spec.Strategy = apps.DeploymentStrategy{ |
| Type: apps.RollingUpdateDeploymentStrategyType, |
| RollingUpdate: &apps.RollingUpdateDeployment{ |
| MaxUnavailable: intstr.FromString("110%"), |
| }, |
| } |
| errorCases["must not be greater than 100%"] = invalidMaxUnavailableDeployment |
| |
| // Rollback.Revision must be non-negative |
| invalidRollbackRevisionDeployment := validDeployment() |
| invalidRollbackRevisionDeployment.Spec.RollbackTo.Revision = -3 |
| errorCases["must be greater than or equal to 0"] = invalidRollbackRevisionDeployment |
| |
| // ProgressDeadlineSeconds should be greater than MinReadySeconds |
| invalidProgressDeadlineDeployment := validDeployment() |
| seconds := int32(600) |
| invalidProgressDeadlineDeployment.Spec.ProgressDeadlineSeconds = &seconds |
| invalidProgressDeadlineDeployment.Spec.MinReadySeconds = seconds |
| errorCases["must be greater than minReadySeconds"] = invalidProgressDeadlineDeployment |
| |
| for k, v := range errorCases { |
| errs := ValidateDeployment(v) |
| if len(errs) == 0 { |
| t.Errorf("[%s] expected failure", k) |
| } else if !strings.Contains(errs[0].Error(), k) { |
| t.Errorf("unexpected error: %q, expected: %q", errs[0].Error(), k) |
| } |
| } |
| } |
| |
| func TestValidateDeploymentStatus(t *testing.T) { |
| collisionCount := int32(-3) |
| tests := []struct { |
| name string |
| |
| replicas int32 |
| updatedReplicas int32 |
| readyReplicas int32 |
| availableReplicas int32 |
| observedGeneration int64 |
| collisionCount *int32 |
| |
| expectedErr bool |
| }{ |
| { |
| name: "valid status", |
| replicas: 3, |
| updatedReplicas: 3, |
| readyReplicas: 2, |
| availableReplicas: 1, |
| observedGeneration: 2, |
| expectedErr: false, |
| }, |
| { |
| name: "invalid replicas", |
| replicas: -1, |
| updatedReplicas: 2, |
| readyReplicas: 2, |
| availableReplicas: 1, |
| observedGeneration: 2, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid updatedReplicas", |
| replicas: 2, |
| updatedReplicas: -1, |
| readyReplicas: 2, |
| availableReplicas: 1, |
| observedGeneration: 2, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid readyReplicas", |
| replicas: 3, |
| readyReplicas: -1, |
| availableReplicas: 1, |
| observedGeneration: 2, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid availableReplicas", |
| replicas: 3, |
| readyReplicas: 3, |
| availableReplicas: -1, |
| observedGeneration: 2, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid observedGeneration", |
| replicas: 3, |
| readyReplicas: 3, |
| availableReplicas: 3, |
| observedGeneration: -1, |
| expectedErr: true, |
| }, |
| { |
| name: "updatedReplicas greater than replicas", |
| replicas: 3, |
| updatedReplicas: 4, |
| readyReplicas: 3, |
| availableReplicas: 3, |
| observedGeneration: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "readyReplicas greater than replicas", |
| replicas: 3, |
| readyReplicas: 4, |
| availableReplicas: 3, |
| observedGeneration: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "availableReplicas greater than replicas", |
| replicas: 3, |
| readyReplicas: 3, |
| availableReplicas: 4, |
| observedGeneration: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "availableReplicas greater than readyReplicas", |
| replicas: 3, |
| readyReplicas: 2, |
| availableReplicas: 3, |
| observedGeneration: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid collisionCount", |
| replicas: 3, |
| observedGeneration: 1, |
| collisionCount: &collisionCount, |
| expectedErr: true, |
| }, |
| } |
| |
| for _, test := range tests { |
| status := apps.DeploymentStatus{ |
| Replicas: test.replicas, |
| UpdatedReplicas: test.updatedReplicas, |
| ReadyReplicas: test.readyReplicas, |
| AvailableReplicas: test.availableReplicas, |
| ObservedGeneration: test.observedGeneration, |
| CollisionCount: test.collisionCount, |
| } |
| |
| errs := ValidateDeploymentStatus(&status, field.NewPath("status")) |
| if hasErr := len(errs) > 0; hasErr != test.expectedErr { |
| errString := spew.Sprintf("%#v", errs) |
| t.Errorf("%s: expected error: %t, got error: %t\nerrors: %s", test.name, test.expectedErr, hasErr, errString) |
| } |
| } |
| } |
| |
| func TestValidateDeploymentStatusUpdate(t *testing.T) { |
| collisionCount := int32(1) |
| otherCollisionCount := int32(2) |
| tests := []struct { |
| name string |
| |
| from, to apps.DeploymentStatus |
| |
| expectedErr bool |
| }{ |
| { |
| name: "increase: valid update", |
| from: apps.DeploymentStatus{ |
| CollisionCount: nil, |
| }, |
| to: apps.DeploymentStatus{ |
| CollisionCount: &collisionCount, |
| }, |
| expectedErr: false, |
| }, |
| { |
| name: "stable: valid update", |
| from: apps.DeploymentStatus{ |
| CollisionCount: &collisionCount, |
| }, |
| to: apps.DeploymentStatus{ |
| CollisionCount: &collisionCount, |
| }, |
| expectedErr: false, |
| }, |
| { |
| name: "unset: invalid update", |
| from: apps.DeploymentStatus{ |
| CollisionCount: &collisionCount, |
| }, |
| to: apps.DeploymentStatus{ |
| CollisionCount: nil, |
| }, |
| expectedErr: true, |
| }, |
| { |
| name: "decrease: invalid update", |
| from: apps.DeploymentStatus{ |
| CollisionCount: &otherCollisionCount, |
| }, |
| to: apps.DeploymentStatus{ |
| CollisionCount: &collisionCount, |
| }, |
| expectedErr: true, |
| }, |
| } |
| |
| for _, test := range tests { |
| meta := metav1.ObjectMeta{Name: "foo", Namespace: metav1.NamespaceDefault, ResourceVersion: "1"} |
| from := &apps.Deployment{ |
| ObjectMeta: meta, |
| Status: test.from, |
| } |
| to := &apps.Deployment{ |
| ObjectMeta: meta, |
| Status: test.to, |
| } |
| |
| errs := ValidateDeploymentStatusUpdate(to, from) |
| if hasErr := len(errs) > 0; hasErr != test.expectedErr { |
| errString := spew.Sprintf("%#v", errs) |
| t.Errorf("%s: expected error: %t, got error: %t\nerrors: %s", test.name, test.expectedErr, hasErr, errString) |
| } |
| } |
| } |
| |
| func validDeploymentRollback() *apps.DeploymentRollback { |
| return &apps.DeploymentRollback{ |
| Name: "abc", |
| UpdatedAnnotations: map[string]string{ |
| "created-by": "abc", |
| }, |
| RollbackTo: apps.RollbackConfig{ |
| Revision: 1, |
| }, |
| } |
| } |
| |
| func TestValidateDeploymentRollback(t *testing.T) { |
| noAnnotation := validDeploymentRollback() |
| noAnnotation.UpdatedAnnotations = nil |
| successCases := []*apps.DeploymentRollback{ |
| validDeploymentRollback(), |
| noAnnotation, |
| } |
| for _, successCase := range successCases { |
| if errs := ValidateDeploymentRollback(successCase); len(errs) != 0 { |
| t.Errorf("expected success: %v", errs) |
| } |
| } |
| |
| errorCases := map[string]*apps.DeploymentRollback{} |
| invalidNoName := validDeploymentRollback() |
| invalidNoName.Name = "" |
| errorCases["name: Required value"] = invalidNoName |
| |
| for k, v := range errorCases { |
| errs := ValidateDeploymentRollback(v) |
| if len(errs) == 0 { |
| t.Errorf("[%s] expected failure", k) |
| } else if !strings.Contains(errs[0].Error(), k) { |
| t.Errorf("unexpected error: %q, expected: %q", errs[0].Error(), k) |
| } |
| } |
| } |
| |
| func TestValidateReplicaSetStatus(t *testing.T) { |
| tests := []struct { |
| name string |
| |
| replicas int32 |
| fullyLabeledReplicas int32 |
| readyReplicas int32 |
| availableReplicas int32 |
| observedGeneration int64 |
| |
| expectedErr bool |
| }{ |
| { |
| name: "valid status", |
| replicas: 3, |
| fullyLabeledReplicas: 3, |
| readyReplicas: 2, |
| availableReplicas: 1, |
| observedGeneration: 2, |
| expectedErr: false, |
| }, |
| { |
| name: "invalid replicas", |
| replicas: -1, |
| fullyLabeledReplicas: 3, |
| readyReplicas: 2, |
| availableReplicas: 1, |
| observedGeneration: 2, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid fullyLabeledReplicas", |
| replicas: 3, |
| fullyLabeledReplicas: -1, |
| readyReplicas: 2, |
| availableReplicas: 1, |
| observedGeneration: 2, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid readyReplicas", |
| replicas: 3, |
| fullyLabeledReplicas: 3, |
| readyReplicas: -1, |
| availableReplicas: 1, |
| observedGeneration: 2, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid availableReplicas", |
| replicas: 3, |
| fullyLabeledReplicas: 3, |
| readyReplicas: 3, |
| availableReplicas: -1, |
| observedGeneration: 2, |
| expectedErr: true, |
| }, |
| { |
| name: "invalid observedGeneration", |
| replicas: 3, |
| fullyLabeledReplicas: 3, |
| readyReplicas: 3, |
| availableReplicas: 3, |
| observedGeneration: -1, |
| expectedErr: true, |
| }, |
| { |
| name: "fullyLabeledReplicas greater than replicas", |
| replicas: 3, |
| fullyLabeledReplicas: 4, |
| readyReplicas: 3, |
| availableReplicas: 3, |
| observedGeneration: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "readyReplicas greater than replicas", |
| replicas: 3, |
| fullyLabeledReplicas: 3, |
| readyReplicas: 4, |
| availableReplicas: 3, |
| observedGeneration: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "availableReplicas greater than replicas", |
| replicas: 3, |
| fullyLabeledReplicas: 3, |
| readyReplicas: 3, |
| availableReplicas: 4, |
| observedGeneration: 1, |
| expectedErr: true, |
| }, |
| { |
| name: "availableReplicas greater than readyReplicas", |
| replicas: 3, |
| fullyLabeledReplicas: 3, |
| readyReplicas: 2, |
| availableReplicas: 3, |
| observedGeneration: 1, |
| expectedErr: true, |
| }, |
| } |
| |
| for _, test := range tests { |
| status := apps.ReplicaSetStatus{ |
| Replicas: test.replicas, |
| FullyLabeledReplicas: test.fullyLabeledReplicas, |
| ReadyReplicas: test.readyReplicas, |
| AvailableReplicas: test.availableReplicas, |
| ObservedGeneration: test.observedGeneration, |
| } |
| |
| if hasErr := len(ValidateReplicaSetStatus(status, field.NewPath("status"))) > 0; hasErr != test.expectedErr { |
| t.Errorf("%s: expected error: %t, got error: %t", test.name, test.expectedErr, hasErr) |
| } |
| } |
| } |
| |
| func TestValidateReplicaSetStatusUpdate(t *testing.T) { |
| validLabels := map[string]string{"a": "b"} |
| validPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| }, |
| }, |
| } |
| type rcUpdateTest struct { |
| old apps.ReplicaSet |
| update apps.ReplicaSet |
| } |
| successCases := []rcUpdateTest{ |
| { |
| old: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| Status: apps.ReplicaSetStatus{ |
| Replicas: 2, |
| }, |
| }, |
| update: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: 3, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| Status: apps.ReplicaSetStatus{ |
| Replicas: 4, |
| }, |
| }, |
| }, |
| } |
| for _, successCase := range successCases { |
| successCase.old.ObjectMeta.ResourceVersion = "1" |
| successCase.update.ObjectMeta.ResourceVersion = "1" |
| if errs := ValidateReplicaSetStatusUpdate(&successCase.update, &successCase.old); len(errs) != 0 { |
| t.Errorf("expected success: %v", errs) |
| } |
| } |
| errorCases := map[string]rcUpdateTest{ |
| "negative replicas": { |
| old: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| Status: apps.ReplicaSetStatus{ |
| Replicas: 3, |
| }, |
| }, |
| update: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| Status: apps.ReplicaSetStatus{ |
| Replicas: -3, |
| }, |
| }, |
| }, |
| } |
| for testName, errorCase := range errorCases { |
| if errs := ValidateReplicaSetStatusUpdate(&errorCase.update, &errorCase.old); len(errs) == 0 { |
| t.Errorf("expected failure: %s", testName) |
| } |
| } |
| |
| } |
| |
| func TestValidateReplicaSetUpdate(t *testing.T) { |
| validLabels := map[string]string{"a": "b"} |
| validPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| }, |
| }, |
| } |
| readWriteVolumePodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| Volumes: []api.Volume{{Name: "gcepd", VolumeSource: api.VolumeSource{GCEPersistentDisk: &api.GCEPersistentDiskVolumeSource{PDName: "my-PD", FSType: "ext4", Partition: 1, ReadOnly: false}}}}, |
| }, |
| }, |
| } |
| invalidLabels := map[string]string{"NoUppercaseOrSpecialCharsLike=Equals": "b"} |
| invalidPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: invalidLabels, |
| }, |
| }, |
| } |
| type rcUpdateTest struct { |
| old apps.ReplicaSet |
| update apps.ReplicaSet |
| } |
| successCases := []rcUpdateTest{ |
| { |
| old: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| update: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: 3, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| }, |
| { |
| old: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| update: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: 1, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: readWriteVolumePodTemplate.Template, |
| }, |
| }, |
| }, |
| } |
| for _, successCase := range successCases { |
| successCase.old.ObjectMeta.ResourceVersion = "1" |
| successCase.update.ObjectMeta.ResourceVersion = "1" |
| if errs := ValidateReplicaSetUpdate(&successCase.update, &successCase.old); len(errs) != 0 { |
| t.Errorf("expected success: %v", errs) |
| } |
| } |
| errorCases := map[string]rcUpdateTest{ |
| "more than one read/write": { |
| old: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| update: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: readWriteVolumePodTemplate.Template, |
| }, |
| }, |
| }, |
| "invalid selector": { |
| old: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| update: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: invalidLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| }, |
| "invalid pod": { |
| old: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| update: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: invalidPodTemplate.Template, |
| }, |
| }, |
| }, |
| "negative replicas": { |
| old: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| update: apps.ReplicaSet{ |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: -1, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| }, |
| } |
| for testName, errorCase := range errorCases { |
| if errs := ValidateReplicaSetUpdate(&errorCase.update, &errorCase.old); len(errs) == 0 { |
| t.Errorf("expected failure: %s", testName) |
| } |
| } |
| } |
| |
| func TestValidateReplicaSet(t *testing.T) { |
| validLabels := map[string]string{"a": "b"} |
| validPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| }, |
| }, |
| } |
| readWriteVolumePodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| Spec: api.PodSpec{ |
| Volumes: []api.Volume{{Name: "gcepd", VolumeSource: api.VolumeSource{GCEPersistentDisk: &api.GCEPersistentDiskVolumeSource{PDName: "my-PD", FSType: "ext4", Partition: 1, ReadOnly: false}}}}, |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| }, |
| }, |
| } |
| invalidLabels := map[string]string{"NoUppercaseOrSpecialCharsLike=Equals": "b"} |
| invalidPodTemplate := api.PodTemplate{ |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyAlways, |
| DNSPolicy: api.DNSClusterFirst, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: invalidLabels, |
| }, |
| }, |
| } |
| successCases := []apps.ReplicaSet{ |
| { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: 1, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: readWriteVolumePodTemplate.Template, |
| }, |
| }, |
| } |
| for _, successCase := range successCases { |
| if errs := ValidateReplicaSet(&successCase); len(errs) != 0 { |
| t.Errorf("expected success: %v", errs) |
| } |
| } |
| |
| errorCases := map[string]apps.ReplicaSet{ |
| "zero-length ID": { |
| ObjectMeta: metav1.ObjectMeta{Name: "", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "missing-namespace": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc-123"}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "empty selector": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "selector_doesnt_match": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: map[string]string{"foo": "bar"}}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "invalid manifest": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| }, |
| }, |
| "read-write persistent disk with > 1 pod": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc"}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: 2, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: readWriteVolumePodTemplate.Template, |
| }, |
| }, |
| "negative_replicas": { |
| ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault}, |
| Spec: apps.ReplicaSetSpec{ |
| Replicas: -1, |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| }, |
| }, |
| "invalid_label": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| Labels: map[string]string{ |
| "NoUppercaseOrSpecialCharsLike=Equals": "bar", |
| }, |
| }, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "invalid_label 2": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| Labels: map[string]string{ |
| "NoUppercaseOrSpecialCharsLike=Equals": "bar", |
| }, |
| }, |
| Spec: apps.ReplicaSetSpec{ |
| Template: invalidPodTemplate.Template, |
| }, |
| }, |
| "invalid_annotation": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| Annotations: map[string]string{ |
| "NoUppercaseOrSpecialCharsLike=Equals": "bar", |
| }, |
| }, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: validPodTemplate.Template, |
| }, |
| }, |
| "invalid restart policy 1": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| }, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyOnFailure, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "ctr", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| }, |
| }, |
| }, |
| "invalid restart policy 2": { |
| ObjectMeta: metav1.ObjectMeta{ |
| Name: "abc-123", |
| Namespace: metav1.NamespaceDefault, |
| }, |
| Spec: apps.ReplicaSetSpec{ |
| Selector: &metav1.LabelSelector{MatchLabels: validLabels}, |
| Template: api.PodTemplateSpec{ |
| Spec: api.PodSpec{ |
| RestartPolicy: api.RestartPolicyNever, |
| DNSPolicy: api.DNSClusterFirst, |
| Containers: []api.Container{{Name: "ctr", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}}, |
| }, |
| ObjectMeta: metav1.ObjectMeta{ |
| Labels: validLabels, |
| }, |
| }, |
| }, |
| }, |
| } |
| for k, v := range errorCases { |
| errs := ValidateReplicaSet(&v) |
| if len(errs) == 0 { |
| t.Errorf("expected failure for %s", k) |
| } |
| for i := range errs { |
| field := errs[i].Field |
| if !strings.HasPrefix(field, "spec.template.") && |
| field != "metadata.name" && |
| field != "metadata.namespace" && |
| field != "spec.selector" && |
| field != "spec.template" && |
| field != "GCEPersistentDisk.ReadOnly" && |
| field != "spec.replicas" && |
| field != "spec.template.labels" && |
| field != "metadata.annotations" && |
| field != "metadata.labels" && |
| field != "status.replicas" { |
| t.Errorf("%s: missing prefix for: %v", k, errs[i]) |
| } |
| } |
| } |
| } |