tree 228c0874451f703a9b4d763a830575df95939081
parent c49e871b02ce8e566455573ae7b074094a079773
author Maxim Smyatkin <smyatkinmaxim@gmail.com> 1778955546 +0300
committer Jianghua.yjh <yjhjstz@gmail.com> 1779370913 -0700

Fix infinite loops in replaceStringInfoString

The function had a few problems:
- replace ="a" and replacement="ab" would give an infinite loop leading
  to OOM. We have a similar case in pg_dump: replace="range",
  replacement="multirange"
- Copying the whole string each time there is a match
- Empty replace pattern also leads to infinite loop

We can still do better: for example count number of matches and do a
single allocation, or even run the replacement inplace. But it's
probably not worth it.