commit 0cc9e273b2eaa37d82a1ae1ac2681aec65aa0f6d
author Caleb Rackliffe <calebrackliffe@gmail.com> Thu Feb 02 11:33:30 2023 -0600
committer Caleb Rackliffe <maedhroz@users.noreply.github.com> Thu Feb 02 14:59:07 2023 -0600
tree 927b90139a1b354dde61b8e52815a45fe38c2243
parent 17eb7e79700dcba1d15d1495b3c11d3a83c12e1b

use equals() rather than reference equality for excluding ourselves from the dependency builder

patch by Benedict; reviewed by Caleb Rackliffe for CASSANDRA-18218

accord-core/src/main/java/accord/messages/PreAccept.java

diff --git a/accord-core/src/main/java/accord/messages/PreAccept.java b/accord-core/src/main/java/accord/messages/PreAccept.java
index 9b171f0..8426cb7 100644
--- a/accord-core/src/main/java/accord/messages/PreAccept.java
+++ b/accord-core/src/main/java/accord/messages/PreAccept.java
@@ -232,7 +232,7 @@
         commandStore.mapReduce(keys, ranges, testKind, STARTED_BEFORE, executeAt, ANY_DEPS, null, null, null,
                 (keyOrRange, testTxnId, testExecuteAt, in) -> {
                     // TODO (easy, efficiency): either pass txnId as parameter or encode this behaviour in a specialised builder to avoid extra allocations
-                    if (testTxnId != txnId)
+                    if (!testTxnId.equals(txnId))
                         in.add(keyOrRange, testTxnId);
                     return in;
                 }, builder, null);