tree d1b8405bd671ab62b6ca2f5fd6f277c2d54c3511
parent 6ea8d098504b50e82475cb13746779eeb8f17b75
author Michal Koziorowski <mkozioro@users.noreply.github.com> 1614847854 +0100
committer Enrico Olivelli <eolivelli@apache.org> 1614847899 +0100

Fix NetworkTopologyImpl#getLeaves returning set with null value in case of non existing scope

Descriptions of the changes in this PR:

NetworkTopologyImpl#getLeaves(String scope) was returning set with null value, when requested scope did not exist.
I've added null check in NetworkTopologyImpl#doGetLeaves(String scope), used by NetworkTopologyImpl#getLeaves method to not have null node returned as leaf node.

It would be nice to have this merged also with non master branch of bookeeper so maintenance releases could have that fix.

### Motivation
I've found my Apache Pulsar cluster polluted with log:
```
 12:01:46.462 pulsar2-dev pulsar-broker {"logLevel":"ERROR","logThread":"pulsar-io-23-1","logger":"org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl","message":"found non-BookieNode: null as leaf of defaultrack: /default-rack","stack_trace":null}
```

After digging I've found that, because https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L324
was returning HashSet with null node, when no bookkeepers were in /default-rack.

### Changes
- Modified doGetLeaves() method to return empty HashSet instead of HashSet with null element when scope node can't be found.


Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Andrey Yegorov <andrey.yegorov@datastax.com>

This closes #2632 from mkozioro/fix-do-get-leaves