| commit | 20ac9e94e3d8939d717fa381fba5dee17e6761a2 | [log] [tgz] |
|---|---|---|
| author | Michal Koziorowski <mkozioro@users.noreply.github.com> | Thu Mar 04 09:50:54 2021 +0100 |
| committer | Enrico Olivelli <eolivelli@apache.org> | Thu Mar 04 09:51:39 2021 +0100 |
| tree | d1b8405bd671ab62b6ca2f5fd6f277c2d54c3511 | |
| parent | 6ea8d098504b50e82475cb13746779eeb8f17b75 [diff] |
Fix NetworkTopologyImpl#getLeaves returning set with null value in case of non existing scope
Descriptions of the changes in this PR:
NetworkTopologyImpl#getLeaves(String scope) was returning set with null value, when requested scope did not exist.
I've added null check in NetworkTopologyImpl#doGetLeaves(String scope), used by NetworkTopologyImpl#getLeaves method to not have null node returned as leaf node.
It would be nice to have this merged also with non master branch of bookeeper so maintenance releases could have that fix.
### Motivation
I've found my Apache Pulsar cluster polluted with log:
```
12:01:46.462 pulsar2-dev pulsar-broker {"logLevel":"ERROR","logThread":"pulsar-io-23-1","logger":"org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl","message":"found non-BookieNode: null as leaf of defaultrack: /default-rack","stack_trace":null}
```
After digging I've found that, because https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L324
was returning HashSet with null node, when no bookkeepers were in /default-rack.
### Changes
- Modified doGetLeaves() method to return empty HashSet instead of HashSet with null element when scope node can't be found.
Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Andrey Yegorov <andrey.yegorov@datastax.com>
This closes #2632 from mkozioro/fix-do-get-leaves
Apache BookKeeper is a scalable, fault tolerant and low latency storage service optimized for append-only workloads.
It is suitable for being used in following scenarios:
Please visit the Documentation from the project website for more information.
For filing bugs, suggesting improvements, or requesting new features, help us out by opening a Github issue or opening an Apache jira.
Subscribe or mail the user@bookkeeper.apache.org list - Ask questions, find answers, and also help other users.
Subscribe or mail the dev@bookkeeper.apache.org list - Join development discussions, propose new ideas and connect with contributors.
Join us on Slack - This is the most immediate way to connect with Apache BookKeeper committers and contributors.
We feel that a welcoming open community is important and welcome contributions.
See Developer Setup to get your local environment setup.
Take a look at our open issues: JIRA Issues Github Issues.
Review our coding style and follow our pull requests to learn about our conventions.
Make your changes according to our contribution guide.