commit | 4292db8dc503d173f06ca4fe542bef5a7c581dee | [log] [tgz] |
---|---|---|
author | hangc0276 <hangc0276@163.com> | Tue May 25 06:46:29 2021 +0800 |
committer | Matteo Merli <mmerli@apache.org> | Fri May 28 21:26:45 2021 -0700 |
tree | 496354049e25eb2ff1d3b6aa4a67276b4d87624c | |
parent | 12f0f5f2ed8496519be2427842173e12bae847a5 [diff] |
fix prometheus metric provider bug and add test to cover label scope … ### Motivation After add label for prometheus metric by https://github.com/apache/bookkeeper/pull/2650, it will cause prometheus metric format check failed when no label specified for a statsLogger. The metric list as follow. ``` replication_bookkeeper_client_bookkeeper_client_bookie_watcher_NEW_ENSEMBLE_TIME{success="false",quantile="0.9999", } NaN ``` ### Modification 1. add label empty check for `PrometheusTextFormatUtil` 2. add label scope check test cover 3. add prometheus metric regex pattern check in test case Reviewers: lipenghui <penghui@apache.org>, Andrey Yegorov <None>, Matteo Merli <mmerli@apache.org>, Jia Zhai <zhaijia@apache.org>, Addison Higham <None>, Enrico Olivelli <eolivelli@gmail.com> This closes #2718 from hangc0276/chenhang/fix_bookeeper_metric_bug and squashes the following commits: 8590704db [hangc0276] format code a6942d49f [chenhang] fix prometheus metric provider bug and add test to cover label scope and metric format check bb8b1e0fe [Andrey Yegorov] Include gradle files into the source artifact for releases, exclude site2/** 732b6cf2a [Andrey Yegorov] [maven-release-plugin] prepare for next development iteration b0d9f1058 [Andrey Yegorov] [maven-release-plugin] prepare branch branch-4.14 8dc108b86 [Matteo Merli] y 73e22cacf [Don Inghram] ISSUE2620: RocksDB log path configurable 034ef8566 [Shoothzj] Fix logger member not correct; (#2605) b824a6029 [hangc0276] fix always select the same region set bug for RegionAwareEnsemblePlacementPolicy (#2658) 683ad4592 [Matteo Merli] Allow to attach labels to metrics (#2650) 809109663 [Matteo Merli] Allow to bypass journal for writes (#2401) 63867a99b [Matteo Merli] Impose a memory limit on the bookie journal (#2710) 87579b0a9 [Matteo Merli] Read entry error should print lastAddConfirmed in the log (#2707)
Apache BookKeeper is a scalable, fault tolerant and low latency storage service optimized for append-only workloads.
It is suitable for being used in following scenarios:
Please visit the Documentation from the project website for more information.
For filing bugs, suggesting improvements, or requesting new features, help us out by opening a Github issue or opening an Apache jira.
Subscribe or mail the user@bookkeeper.apache.org list - Ask questions, find answers, and also help other users.
Subscribe or mail the dev@bookkeeper.apache.org list - Join development discussions, propose new ideas and connect with contributors.
Join us on Slack - This is the most immediate way to connect with Apache BookKeeper committers and contributors.
We feel that a welcoming open community is important and welcome contributions.
See Developer Setup to get your local environment setup.
Take a look at our open issues: JIRA Issues Github Issues.
Review our coding style and follow our pull requests to learn about our conventions.
Make your changes according to our contribution guide.