tree e680c0daf1f4d80b7beb26fe33983afd27479d67
parent fca0a071c3be99326b9075c24ff17ce76faf7bda
author Enrico Olivelli <eolivelli@gmail.com> 1589867786 +0200
committer GitHub <noreply@github.com> 1589867786 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJew3UKCRBK7hj4Ov3rIwAAdHIIALEiu2eHXvSweB/U/tditOMV
 cA8sf6R5z1gGFI2DHvImVPupVrzsG/2qegDFvnmYDIxul+d/6jxohzwzr7So60Pv
 2+tV1huG0PoSFIvpHa003YJ1BHOJL/gBbEuuldRFGnXDoTaD6jFZMd7hZT6lR43g
 iQ5lrRmqf+WbHNMVF/TkDEHPIxkOIJ+jPvH90Vbu6asc5A/EwUtX21jtHr2QB8FU
 AnwXLPXGZtagUsoXtzNvpIJEhddGf5st5e1tP/aYAz1zwwibjGiC17kdRAu8OMyi
 31+f9ebSodiHHkYistBXAvoJaK0FEe0EF75+4+2VWkPPGmuSmw6G8rv73WZrHbk=
 =JOcZ
 -----END PGP SIGNATURE-----
 

QuorumCoverage should only count unknown nodes

The original patch was contributed by ivankelly in PR #2303, I have only fixed checkstyle and removed two tests that were wrong.

Quorum coverage checks if we have heard from enough nodes to know that
there is no entry that can have been written to enough nodes that we
haven't heard from to have formed an ack quorum.

The coverage algorithm was correct pre-5e399df.

5e399df(BOOKKEEPER-759: Delay Ensemble Change & Disable Ensemble
Change) broke this, but it still seems to have worked because they had
a broken else statement at the end. Why a change which is 100% about
the write-path changed something in the read-path is a mystery.

dcdd1e(Small fix wrong nodesUninitialized count when checkCovered)
went on to fix the broken fix, so the whole thing ended up broke.

The change also modifies ReadLastConfirmedOp to make it testable.

Reviewers: Sijie Guo <None>, Rajan Dhabalia <rdhabalia@apache.org>

This closes #2333 from eolivelli/pr2303