commit | cb284995fbfc23441be10b4465ed2985b64d5ae4 | [log] [tgz] |
---|---|---|
author | Chris Bartholomew <chris.bartholomew@kafkaesque.io> | Mon Feb 01 20:57:15 2021 -0500 |
committer | GitHub <noreply@github.com> | Mon Feb 01 17:57:15 2021 -0800 |
tree | 1d94b80f9f547fc7ae84ef01df44d8dd53b5b0b2 | |
parent | a7f2a2eceaaeb4e101c6fd51a6868b48c8d1214f [diff] |
Stream storage endpoint from hostname to return fully-qualified name in Java 11+ Descriptions of the changes in this PR: Update how hostname is retrieved when using hostname as identifier for stream storage to work consistenly between Java 8 and Java 11. ### Motivation Between Java 8 and Java 11, the value returned by `InetAddress.getLocalHost().getHostName()` changed from being the fully qualified name to just the short hostname. When running in a Kubernetes environment, it is necessary for the endpoint to be identied by its fully qualified name so that clients can connect. This same change was made in Pulsar in https://github.com/apache/pulsar/pull/6235. I have tested this change in Kubernetes environment using Java 11. ### Changes This is a simple change from `getHostName` to `getCanonicalHostName()`. Master Issue: #2559 Reviewers: Andrey Yegorov <None>, Enrico Olivelli <eolivelli@gmail.com> This closes #2571 from cdbartholomew/stream-storage-endpoint-java11
Apache BookKeeper is a scalable, fault tolerant and low latency storage service optimized for append-only workloads.
It is suitable for being used in following scenarios:
Please visit the Documentation from the project website for more information.
For filing bugs, suggesting improvements, or requesting new features, help us out by opening a Github issue or opening an Apache jira.
Subscribe or mail the user@bookkeeper.apache.org list - Ask questions, find answers, and also help other users.
Subscribe or mail the dev@bookkeeper.apache.org list - Join development discussions, propose new ideas and connect with contributors.
Join us on Slack - This is the most immediate way to connect with Apache BookKeeper committers and contributors.
We feel that a welcoming open community is important and welcome contributions.
See Developer Setup to get your local environment setup.
Take a look at our open issues: JIRA Issues Github Issues.
Review our coding style and follow our pull requests to learn about our conventions.
Make your changes according to our contribution guide.