commit | c1847af5a6d75436aafd13501cb15973ea6b4995 | [log] [tgz] |
---|---|---|
author | Prashant Kumar <65131575+pkumar-singh@users.noreply.github.com> | Tue May 25 14:56:31 2021 -0700 |
committer | GitHub <noreply@github.com> | Tue May 25 14:56:31 2021 -0700 |
tree | a7d6b5a8177bb10d0f9e5cee67f6e285af408a44 | |
parent | 9417b68ca072661efa0d3860e5b769338ba9d52c [diff] |
Turn Bookie into an interface ### Motivation Bookie was previously a concrete class that was used and abused all over the place, especially in tests. A classic example of the God object antipattern. The extensive use in tests, resulted in test cases which spin up many instances of the whole system, which is very heavy and very slow, especially when trying to unit tests a particular feature. This change is the first step to resolving this situation. Bookie is now an interface, implemented by BookieImpl. Subsequent changes will break out parts of the interface, cleanup calls and add dependency injection. Reviewers: Matteo Merli <mmerli@apache.org>, Andrey Yegorov, Henry Saputra <hsaputra@apache.org>, Enrico Olivelli <eolivelli@gmail.com> This closes #2717 from pkumar-singh/merge_back_to_oss and squashes the following commits: 3edee4958 [Prashant] Replace SettableFuture with CompletableFuture db690262a [Ivan Kelly] Turn Bookie into an interface
Apache BookKeeper is a scalable, fault tolerant and low latency storage service optimized for append-only workloads.
It is suitable for being used in following scenarios:
Please visit the Documentation from the project website for more information.
For filing bugs, suggesting improvements, or requesting new features, help us out by opening a Github issue or opening an Apache jira.
Subscribe or mail the user@bookkeeper.apache.org list - Ask questions, find answers, and also help other users.
Subscribe or mail the dev@bookkeeper.apache.org list - Join development discussions, propose new ideas and connect with contributors.
Join us on Slack - This is the most immediate way to connect with Apache BookKeeper committers and contributors.
We feel that a welcoming open community is important and welcome contributions.
See Developer Setup to get your local environment setup.
Take a look at our open issues: JIRA Issues Github Issues.
Review our coding style and follow our pull requests to learn about our conventions.
Make your changes according to our contribution guide.