| commit | b96a5a75403f3260b564ca8c5d5889af51fe9872 | [log] [tgz] |
|---|---|---|
| author | Enrico Olivelli <eolivelli@gmail.com> | Mon Jul 27 15:06:29 2020 +0200 |
| committer | GitHub <noreply@github.com> | Mon Jul 27 15:06:29 2020 +0200 |
| tree | 16393309c7bf239c2fc2e53e6eec806da4ad7571 | |
| parent | 96f9c5a1b3a0b74d641a288544b6a3a0aa986574 [diff] |
Track ZooKeeper errors as causes of ZKException
Descriptions of the changes in this PR:
### Motivation
Every time a problem with ZK arises you don't see it in the exception chain of the BKException (in this case ZKException) and you end up with errors like:
```
org.apache.bookkeeper.client.BKException$ZKException: Error while using ZooKeeper
at org.apache.bookkeeper.client.SyncCallbackUtils.finish(SyncCallbackUtils.java:83)
at org.apache.bookkeeper.client.SyncCallbackUtils$SyncAddCallback.addComplete(SyncCallbackUtils.java:251)
at org.apache.bookkeeper.client.AsyncCallback$AddCallback.addCompleteWithLatency(AsyncCallback.java:91)
at org.apache.bookkeeper.client.PendingAddOp.submitCallback(PendingAddOp.java:430)
at org.apache.bookkeeper.client.LedgerHandle.errorOutPendingAdds(LedgerHandle.java:1784)
at org.apache.bookkeeper.client.LedgerHandle$5.safeRun(LedgerHandle.java:574)
```
### Changes
Add a "cause" to every ZKException.
### Notes
There are very few places that cannot be fixed because they are still using the old callback based mechanism without CompletableFuture. Those points are not changed in order to make the patch simple but still useful.
Reviewers: Jia Zhai <zhaijia@apache.org>
This closes #2384 from eolivelli/fix/zkexception-chain
Apache BookKeeper is a scalable, fault tolerant and low latency storage service optimized for append-only workloads.
It is suitable for being used in following scenarios:
You can also read Turning Ledgers into Logs to learn how to turn ledgers into continuous log streams. If you are looking for a high level log stream API, you can checkout DistributedLog.
For filing bugs, suggesting improvements, or requesting new features, help us out by opening a Github issue or opening an Apache jira.
Subscribe or mail the user@bookkeeper.apache.org list - Ask questions, find answers, and also help other users.
Subscribe or mail the dev@bookkeeper.apache.org list - Join development discussions, propose new ideas and connect with contributors.
Join us on Slack - This is the most immediate way to connect with Apache BookKeeper committers and contributors.
We feel that a welcoming open community is important and welcome contributions.
See Developer Setup to get your local environment setup.
Take a look at our open issues: JIRA Issues Github Issues.
Review our coding style and follow our pull requests to learn about our conventions.
Make your changes according to our contribution guide.