tree 5093f574accac9537fa6ccafd97e6b2a31a82210
parent 51bfd221f8e35c7a69a35286a8988e0dd01ac11b
author Anup Ghatage <ghatage@apache.org> 1603807121 -0700
committer GitHub <noreply@github.com> 1603807121 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJfmCeRCRBK7hj4Ov3rIwAAdHIIAGhseH7i3oLopO8jUuI9Ncuv
 5oM59B3X+DtVmn0gySIUdliTevawNY5HW4v7z1dMrLMG3CpOLj5HDaqUWx62h+u5
 KOuGh8Yk5crCCG4agdrUFxG15/KX6cPE2xKBeoB0F7Dg/ogEXK4G6rBTvxpi6OqV
 TDj6n6U2zbGv2eNeLGhe4V0/p2WreYRfc6s4FaITY0tpH5NtiQg0Q2jw4VPMUD3Z
 PGe+lpQ/x6Ut8W/Mxvt/l7S10hIFJOQ3J63An3oa21hQiBZAjg6/0ml9IsCDgpmD
 k456FiRukTkMoJZNsahvFsbaxrY4z5dF4s5ZecCv3c8TtdoUqvY6q7CsJg16VCc=
 =cGNJ
 -----END PGP SIGNATURE-----
 

BP-40: Convert all System.*.print statements to LOG.* statements

### Motivation

In order to have an audit log of all user interactions, all print statements which come from such interactions need to be logged.
We have two user driven ways to mutate BookKeeper:
* BookieShell
* bkctl
Both internally use the same code from `tools/cli`

### Changes

The logging in the code was inconsistent. At times we used `System.out.println` and at times we used `LOG.info`.
As a part of this work item we change these in the following way:

* For every `cli` class, confirm if a Logger object is present, if not create one.
* Convert all `System.out.println()` -> `LOG.info()`
* Convert all `System.err.println()` -> `LOG.error()`

### Ramifications

BookieShell uses `log4j.shell.properties`
bkctl uses `log4j.cli.properties`

Both log4j property files have `CONSOLE appenders`, so the like previous `System.out.println()`, the new `LOG` statements will also be printed to console.
This is mentioned explicitly as certain upstream consumers / scripts utilize BookieShell / bkctl to assess the state of the BK cluster.

Master Issue: #2209 


Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2455 from Ghatage/BP-40/auditLogging