tree 6085655790e9a3687f5f61d297b7b0577d79dc92
parent c1847af5a6d75436aafd13501cb15973ea6b4995
author Prashant Kumar <65131575+pkumar-singh@users.noreply.github.com> 1622158176 -0700
committer GitHub <noreply@github.com> 1622158176 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJgsCtgCRBK7hj4Ov3rIwAAM1sIAAE2+dJ2ODlM6QagHI9bb+Q7
 PJWTZVvhX+R4mzq4MD1vJA1KSTtsBt2vq3X9USQkg4nGbw5TmGvEGdznuPpNci2H
 +uvbEKRJFAcPJtditrJejkI4/RsDXNsqobCqUAcdVVrA6H5XoQdyvS0mvFrfbci/
 qBCXqZQdiW8BDojuO4qmBS3bFTMM3D99iwyfJSCjycj8BYNV/7CTyFNTyLfxnDMf
 8Uy7+CF31dphzVc2R6CMotkAT04JDwRnRetfFbngLKt9F6i/LYVtcf8VQIjMsP73
 HLLCpJrjHb8lryHmSfUsHrMePw+cXTLIg/ZM6P76bPGPJmkVXS/8H3P/a/GqivI=
 =0WD1
 -----END PGP SIGNATURE-----
 

Refactor book keeper cluster test case

### Motivation
BookKeeperClusterTestCase has historically exposed its members to all
subclasses, which would then manipulate them in many ways. There was
an array of objects for configurations, bookieServers, autorecovery,
which implicit linking between the objects based on maps and indices.
Individual subclasses manipulated these arrays.

This makes it hard to add any dependency injection on the objects
managed by BookKeeperClusterTestCase as the objects. To add DI, we
need each object to have a bunch of other objects associated with
it. For example, for each Bookie, we need to create the
Journal. Maintaining these in separate arrays will lead to fragile
tests.

This change encapsulates all the testing objects in a per bookie
object, and only allows manipulation through methods. This will allow
us to group the objects needed for DI clearly.

Disable testFollowBookieAddressChangeTrckingDisabled

Reviewers: Henry Saputra <hsaputra@apache.org>, Matteo Merli <mmerli@apache.org>

This closes #2723 from pkumar-singh/refactor_BookKeeperClusterTestCase and squashes the following commits:

47fb8121f [Prashant] Addressed code review comments
7f410ce96 [Ivan Kelly] Encapulate members of BookKeeperClusterTestCase
c1847af5a [Prashant Kumar] Turn Bookie into an interface
9417b68ca [Andrey Yegorov] site update for release 4.14, this time actually updating the latest version in _config.yml (#2722)