commit | 737f92b2782fc0d027c51ea6bf88cb6b802398db | [log] [tgz] |
---|---|---|
author | Ivan Kelly <ivank@apache.org> | Fri Jan 25 05:09:10 2019 +0100 |
committer | Sijie Guo <guosijie@gmail.com> | Thu Jan 24 20:09:10 2019 -0800 |
tree | b77fd8fa53d9cd68f0536d9082966c65326b2c43 | |
parent | 03e7d6e48822e656d6b652359f780f0cb1513bc1 [diff] |
Add semantically meaningful return values to placement policy Currently newEnsemble and replaceBookie in EnsemblePlacementPolicy return a apache commons Pair<> with the second argument being a boolean to denote whether the placement conforms strictly to the policy. From calling code, the meaning of this second value is unclear. This patch replaces Pair<> with an PlacementResult object, in which the strict conformity argument is clearly labels. This will also allow extension in the future to return more metadata about particular placements. Also, we shouldn't put third party library classes in interfaces. Issue: #1914 Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Charan Reddy Guttapalem <reddycharan18@gmail.com>, Sijie Guo <sijie@apache.org> This closes #1916 from ivankelly/meaningful-placement-res
Apache BookKeeper is a scalable, fault tolerant and low latency storage service optimized for append-only workloads.
It is suitable for being used in following scenarios:
You can also read Turning Ledgers into Logs to learn how to turn ledgers into continuous log streams. If you are looking for a high level log stream API, you can checkout DistributedLog.
For filing bugs, suggesting improvements, or requesting new features, help us out by opening a Github issue or opening an Apache jira.
Subscribe or mail the user@bookkeeper.apache.org list - Ask questions, find answers, and also help other users.
Subscribe or mail the dev@bookkeeper.apache.org list - Join development discussions, propose new ideas and connect with contributors.
Join us on Slack - This is the most immediate way to connect with Apache BookKeeper committers and contributors.
We feel that a welcoming open community is important and welcome contributions.
See Developer Setup to get your local environment setup.
Take a look at our open issues: JIRA Issues Github Issues.
Review our coding style and follow our pull requests to learn about our conventions.
Make your changes according to our contribution guide.