commit | 4f56edf012de8fbf1e33657b390f01fc823aa2c4 | [log] [tgz] |
---|---|---|
author | Ivan Kelly <ivank@apache.org> | Wed Oct 23 10:49:00 2019 +0200 |
committer | GitHub <noreply@github.com> | Wed Oct 23 10:49:00 2019 +0200 |
tree | 286d7cc13ec2006d366d149caa67e5086979d7de | |
parent | 7c24301856fcc502ae2c595195cf48ac62ffe47d [diff] |
[DLOG] LogReader shouldn't be added to pending if not locking The pendingReaders set in BKDistributedLogManager exists so that if the manager is closed which the lock is being acquired for a reader, that reader will be closed (even though it hasn't been returned to the client). In the case that the reader is opened without a lock, there is not async action being performed. Previously we were also adding these readers to the pendingReaders, but they were never being removed from the pendingReaders, causing a memory leak. This change avoids adding no-locking readers to pendingReaders. Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2185 from ivankelly/orphan-reader
Apache BookKeeper is a scalable, fault tolerant and low latency storage service optimized for append-only workloads.
It is suitable for being used in following scenarios:
You can also read Turning Ledgers into Logs to learn how to turn ledgers into continuous log streams. If you are looking for a high level log stream API, you can checkout DistributedLog.
For filing bugs, suggesting improvements, or requesting new features, help us out by opening a Github issue or opening an Apache jira.
Subscribe or mail the user@bookkeeper.apache.org list - Ask questions, find answers, and also help other users.
Subscribe or mail the dev@bookkeeper.apache.org list - Join development discussions, propose new ideas and connect with contributors.
Join us on Slack - This is the most immediate way to connect with Apache BookKeeper committers and contributors.
We feel that a welcoming open community is important and welcome contributions.
See Developer Setup to get your local environment setup.
Take a look at our open issues: JIRA Issues Github Issues.
Review our coding style and follow our pull requests to learn about our conventions.
Make your changes according to our contribution guide.