Google Git
Sign in
apache / bookkeeper / 25264f997ef22d9f456a9b88832dfa6634927b60
commit25264f997ef22d9f456a9b88832dfa6634927b60[log] [tgz]
authorKevin Wilson <klwilson227@comcast.net>Mon Apr 05 22:02:57 2021 -0600
committerGitHub <noreply@github.com>Tue Apr 06 12:02:57 2021 +0800
tree472810b91bc8662634e0f51b8db0decdcb89713a
parentae023fd5fab1f015229e475de106df46144bd4d0 [diff]
Fix logic in Bookkeeper forceAllowCompaction to run only when force is set or configured interval (#2675)

Without the attached fix, when forceAllowCompaction and isForceGCAllowWhenNoSpace are set. The majorCompaction runs with every garbage collection. This results due to the fact that enableMajorCompaction which takes a negative interval into account to disable compaction always returns true since the difference in time will always be larger than -1. The time check must be "and" with the enableMajorCompaciton for the time check to be valid. And the force flag may also be valid when the isForce(Major/Minor)CompactionAllow is set to true which will validate the threshold in the force case is set.
2 files changed
tree: 472810b91bc8662634e0f51b8db0decdcb89713a
  1. .github/
  2. .test-infra/
  3. bin/
  4. bookkeeper-benchmark/
  5. bookkeeper-common/
  6. bookkeeper-common-allocator/
  7. bookkeeper-dist/
  8. bookkeeper-http/
  9. bookkeeper-proto/
  10. bookkeeper-server/
  11. bookkeeper-stats/
  12. bookkeeper-stats-providers/
  13. buildtools/
  14. circe-checksum/
  15. conf/
  16. cpu-affinity/
  17. deploy/
  18. dev/
  19. docker/
  20. gradle/
  21. metadata-drivers/
  22. microbenchmarks/
  23. shaded/
  24. site/
  25. site2/
  26. stats/
  27. stream/
  28. tests/
  29. tools/
  30. .gitignore
  31. build.gradle
  32. dependencies.gradle
  33. gradle.properties
  34. gradlew
  35. gradlew.bat
  36. Jenkinsfile
  37. LICENSE
  38. NOTICE
  39. pom.xml
  40. README.md
  41. settings.gradle
  42. version.gradle
README.md

Build Status Build Status Coverage Status Maven Central

Apache BookKeeper

Apache BookKeeper is a scalable, fault tolerant and low latency storage service optimized for append-only workloads.

It is suitable for being used in following scenarios:

  • WAL (Write-Ahead-Logging), e.g. HDFS NameNode.
  • Message Store, e.g. Apache Pulsar.
  • Offset/Cursor Store, e.g. Apache Pulsar.
  • Object/Blob Store, e.g. storing state machine snapshots.

Get Started

  • Checkout the project website.
  • Concepts: Start with the basic concepts of Apache BookKeeper. This will help you to fully understand the other parts of the documentation.
  • Follow the Install guide to setup BookKeeper.

Documentation

Please visit the Documentation from the project website for more information.

Get In Touch

Report a Bug

For filing bugs, suggesting improvements, or requesting new features, help us out by opening a Github issue or opening an Apache jira.

Need Help?

Subscribe or mail the user@bookkeeper.apache.org list - Ask questions, find answers, and also help other users.

Subscribe or mail the dev@bookkeeper.apache.org list - Join development discussions, propose new ideas and connect with contributors.

Join us on Slack - This is the most immediate way to connect with Apache BookKeeper committers and contributors.

Contributing

We feel that a welcoming open community is important and welcome contributions.

Contributing Code

  1. See Developer Setup to get your local environment setup.

  2. Take a look at our open issues: JIRA Issues Github Issues.

  3. Review our coding style and follow our pull requests to learn about our conventions.

  4. Make your changes according to our contribution guide.

Improving Website and Documentation

  1. See Building the website and documentation on how to build the website and documentation.