commit | 1efdc1c0807fc7151595c1bb0414ea1dd255e48d | [log] [tgz] |
---|---|---|
author | hangc0276 <hangc0276@163.com> | Wed Jan 27 15:41:02 2021 +0800 |
committer | GitHub <noreply@github.com> | Wed Jan 27 08:41:02 2021 +0100 |
tree | 75e3590593e85a8c27d697bd443be9add81b3290 | |
parent | c5d7026cc38ce3fdfcac8f569327c1d4837813ad [diff] |
fix default value in bk_server.conf, sync with code default value ### Motivation Fix the default value in `bk_server.conf`, sync with the default value in code. For `readAheadCacheBatchSize` in code default value. ``` Java private static final int DEFAULT_READ_AHEAD_CACHE_BATCH_SIZE = 100; readAheadCacheBatchSize = conf.getInt(READ_AHEAD_CACHE_BATCH_SIZE, DEFAULT_READ_AHEAD_CACHE_BATCH_SIZE); ``` So, it should be 100 in `bk_server.conf` default configuration. For `dbStorage_readAheadCacheMaxSizeMb` in code default value. ```Java public static final String READ_AHEAD_CACHE_MAX_SIZE_MB = "dbStorage_readAheadCacheMaxSizeMb"; private static final long DEFAULT_READ_CACHE_MAX_SIZE_MB = (long) (0.25 * PlatformDependent.maxDirectMemory()) / MB; long readCacheMaxSize = getLongVariableOrDefault(conf, READ_AHEAD_CACHE_MAX_SIZE_MB, DEFAULT_READ_CACHE_MAX_SIZE_MB) * MB; ``` So, it should be 25% of direct memory in `bk_server.conf` default configuration. Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes #2533 from hangc0276/update_doc_default_value
Apache BookKeeper is a scalable, fault tolerant and low latency storage service optimized for append-only workloads.
It is suitable for being used in following scenarios:
Please visit the Documentation from the project website for more information.
For filing bugs, suggesting improvements, or requesting new features, help us out by opening a Github issue or opening an Apache jira.
Subscribe or mail the user@bookkeeper.apache.org list - Ask questions, find answers, and also help other users.
Subscribe or mail the dev@bookkeeper.apache.org list - Join development discussions, propose new ideas and connect with contributors.
Join us on Slack - This is the most immediate way to connect with Apache BookKeeper committers and contributors.
We feel that a welcoming open community is important and welcome contributions.
See Developer Setup to get your local environment setup.
Take a look at our open issues: JIRA Issues Github Issues.
Review our coding style and follow our pull requests to learn about our conventions.
Make your changes according to our contribution guide.