commit | 9f06a4ce82f61a9dc4b086650a301734332f4246 | [log] [tgz] |
---|---|---|
author | Prashant Kumar <65131575+pkumar-singh@users.noreply.github.com> | Thu May 27 16:29:36 2021 -0700 |
committer | GitHub <noreply@github.com> | Thu May 27 16:29:36 2021 -0700 |
tree | 6085655790e9a3687f5f61d297b7b0577d79dc92 | |
parent | c1847af5a6d75436aafd13501cb15973ea6b4995 [diff] |
Refactor book keeper cluster test case ### Motivation BookKeeperClusterTestCase has historically exposed its members to all subclasses, which would then manipulate them in many ways. There was an array of objects for configurations, bookieServers, autorecovery, which implicit linking between the objects based on maps and indices. Individual subclasses manipulated these arrays. This makes it hard to add any dependency injection on the objects managed by BookKeeperClusterTestCase as the objects. To add DI, we need each object to have a bunch of other objects associated with it. For example, for each Bookie, we need to create the Journal. Maintaining these in separate arrays will lead to fragile tests. This change encapsulates all the testing objects in a per bookie object, and only allows manipulation through methods. This will allow us to group the objects needed for DI clearly. Disable testFollowBookieAddressChangeTrckingDisabled Reviewers: Henry Saputra <hsaputra@apache.org>, Matteo Merli <mmerli@apache.org> This closes #2723 from pkumar-singh/refactor_BookKeeperClusterTestCase and squashes the following commits: 47fb8121f [Prashant] Addressed code review comments 7f410ce96 [Ivan Kelly] Encapulate members of BookKeeperClusterTestCase c1847af5a [Prashant Kumar] Turn Bookie into an interface 9417b68ca [Andrey Yegorov] site update for release 4.14, this time actually updating the latest version in _config.yml (#2722)
Apache BookKeeper is a scalable, fault tolerant and low latency storage service optimized for append-only workloads.
It is suitable for being used in following scenarios:
Please visit the Documentation from the project website for more information.
For filing bugs, suggesting improvements, or requesting new features, help us out by opening a Github issue or opening an Apache jira.
Subscribe or mail the user@bookkeeper.apache.org list - Ask questions, find answers, and also help other users.
Subscribe or mail the dev@bookkeeper.apache.org list - Join development discussions, propose new ideas and connect with contributors.
Join us on Slack - This is the most immediate way to connect with Apache BookKeeper committers and contributors.
We feel that a welcoming open community is important and welcome contributions.
See Developer Setup to get your local environment setup.
Take a look at our open issues: JIRA Issues Github Issues.
Review our coding style and follow our pull requests to learn about our conventions.
Make your changes according to our contribution guide.