tree 3db9dbcaa32d8dbb17962d5f42d8a781196a6b55
parent c05632b219346abd483937933c04a2ad92bca3d2
author Jordan Ly <jordan.ly8@gmail.com> 1523490419 -0700
committer Jordan Ly <jly@twitter.com> 1523490419 -0700

Remove flaky test/assertion in PendingTaskProcessorTest

I realized I added a flaky assertion in `PendingTaskProcessorTest` in
https://reviews.apache.org/r/66536/

I got extremely unlucky and every time I ran the tests it passed until after
I merged :( The stat `preemptor_slot_search_[success|failed]_for_[name]` will
not appear unless the job slot search actually succeeds or fails (i.e. it
cannot be 0 since it is dynamically generated). We were getting lucky where the
test would search for JOB_A slots first and create the stat. However, when
JOB_B gets searched first, the JOB_A stat is never created because there are no
slaves to search through anymore.

I removed the assertion because there is a sufficient assertion directly above,
and the stat is tested in multiple other tests.

The assertion would result in a `NullPointerException`.

Reviewed at https://reviews.apache.org/r/66570/