Google Git
Sign in
apache / arrow / a708fabfe6f90a890978d8f026c70cdf18caf251
commita708fabfe6f90a890978d8f026c70cdf18caf251[log] [tgz]
authorStephan T. Lavavej <stl@microsoft.com>Thu Jun 06 19:25:36 2024 -0700
committerGitHub <noreply@github.com>Fri Jun 07 11:25:36 2024 +0900
tree8ce568fc0d0c5951c44a4de801cdfe3258600f54
parent41ae29ebd98e66d1502d6a830f88d6da056c670e [diff]
MINOR: [C++] Include `<string>` before using `std::string` (#42004)

### Rationale for this change

I work on MSVC's STL, and we regularly build popular open-source projects, including yours, with development builds of the MSVC toolset. This allows us to find and fix toolset regressions before they affect users, and also allows us to provide advance notice of breaking changes, which is the case here.

We recently merged https://github.com/microsoft/STL/pull/4633 which will ship in VS 2022 17.11 Preview 3. This improved build throughput by refactoring `<string_view>` so that it no longer drags in `std::string`. It's also a source-breaking change for code that wasn't properly including `<string>`. Your `cpp/src/arrow/json/object_writer.h` declares `std::string Serialize();` without including `<string>`. When built with our updated STL, this will emit a compiler error:

```
C:\gitP\apache\arrow\cpp\src\arrow/json/object_writer.h(39): error C2039: 'string': is not a member of 'std'
```

### What changes are included in this PR?

The fix is simple and portable: include the necessary header.

### Are these changes tested?

Nope, I'm totally YOLOing it. If it builds, it's good.

(This will be tested in MSVC's internal "Real World Code" test infrastructure. Also, after VS 2022 17.11 ships, your existing build/test coverage will ensure that this keeps compiling.)

### Are there any user-facing changes?

No.

Authored-by: Stephan T. Lavavej <stl@microsoft.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
1 file changed
tree: 8ce568fc0d0c5951c44a4de801cdfe3258600f54
  1. .github/
  2. .mvn/
  3. c_glib/
  4. ci/
  5. cpp/
  6. csharp/
  7. dev/
  8. docs/
  9. format/
  10. go/
  11. java/
  12. js/
  13. matlab/
  14. python/
  15. r/
  16. ruby/
  17. swift/
  18. testing
  19. .asf.yaml
  20. .clang-format
  21. .clang-tidy
  22. .clang-tidy-ignore
  23. .dir-locals.el
  24. .dockerignore
  25. .env
  26. .gitattributes
  27. .gitignore
  28. .gitmodules
  29. .golangci.yaml
  30. .hadolint.yaml
  31. .pre-commit-config.yaml
  32. .readthedocs.yml
  33. appveyor.yml
  34. CHANGELOG.md
  35. cmake-format.py
  36. CODE_OF_CONDUCT.md
  37. CONTRIBUTING.md
  38. docker-compose.yml
  39. header
  40. LICENSE.txt
  41. NOTICE.txt
  42. README.md
README.md

Apache Arrow

Fuzzing Status License Twitter Follow

Powering In-Memory Analytics

Apache Arrow is a development platform for in-memory analytics. It contains a set of technologies that enable big data systems to process and move data fast.

Major components of the project include:

Arrow is an Apache Software Foundation project. Learn more at arrow.apache.org.

What's in the Arrow libraries?

The reference Arrow libraries contain many distinct software components:

  • Columnar vector and table-like containers (similar to data frames) supporting flat or nested types
  • Fast, language agnostic metadata messaging layer (using Google's Flatbuffers library)
  • Reference-counted off-heap buffer memory management, for zero-copy memory sharing and handling memory-mapped files
  • IO interfaces to local and remote filesystems
  • Self-describing binary wire formats (streaming and batch/file-like) for remote procedure calls (RPC) and interprocess communication (IPC)
  • Integration tests for verifying binary compatibility between the implementations (e.g. sending data from Java to C++)
  • Conversions to and from other in-memory data structures
  • Readers and writers for various widely-used file formats (such as Parquet, CSV)

Implementation status

The official Arrow libraries in this repository are in different stages of implementing the Arrow format and related features. See our current feature matrix on git main.

How to Contribute

Please read our latest project contribution guide.

Getting involved

Even if you do not plan to contribute to Apache Arrow itself or Arrow integrations in other projects, we'd be happy to have you involved: