Google Git
Sign in
apache / arrow / a1376879ced6c0bc14dcc1e27c0c23c6ad1554a9
commita1376879ced6c0bc14dcc1e27c0c23c6ad1554a9[log] [tgz]
authorFelipe Oliveira Carvalho <felipekde@gmail.com>Wed Jul 17 13:39:22 2024 -0300
committerGitHub <noreply@github.com>Wed Jul 17 13:39:22 2024 -0300
tree6f219f14132ab4ea0a72fe5061727e0aa2ead44a
parentc66b3f149f92e1fae0b33cc63c6093db2deedd29 [diff]
GH-43185: [C++] Suggest a cast when Concatenate fails due to offsets overflow (#43190)

## Rationale for this change

When arrays using 32-bit offsets into data buffers are concatenated and the data buffers of the results grow beyond 2GB, `Concatenate` returns a bad `Status` with a very simple message:

`"offset overflow while concatenating arrays"`

The contract that `Concatenate` honors is very simple: arrays of input type T lead to output of the same type T, so we can't, for instance, return a `LARGE_STRING` [1] array when the input is `STRING`.

But we can **suggest a cast** to the caller in case an overflow error is detected. Either programatically (by taking an output parameter) or by giving a better error message to users.

[1] `LARGE_STRING` can use 64-bit offsets

### What changes are included in this PR?

 - Suggest casts when concatenation of the values of an FSL fail due to overflow
 - Suggest casts when concatenation of [LARGE_]LIST_VIEW array fails due to overflow
 - Suggest casts when concatenation of [LARGE_]LIST array fails due to overflow
 - Suggest a cast to LARGE_(BINARY|STRING) when offsets overflow

### Are these changes tested?

Yes.
* GitHub Issue: #43185

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
3 files changed
tree: 6f219f14132ab4ea0a72fe5061727e0aa2ead44a
  1. .github/
  2. c_glib/
  3. ci/
  4. cpp/
  5. csharp/
  6. dev/
  7. docs/
  8. format/
  9. go/
  10. java/
  11. js/
  12. matlab/
  13. python/
  14. r/
  15. ruby/
  16. swift/
  17. testing
  18. .asf.yaml
  19. .clang-format
  20. .clang-tidy
  21. .clang-tidy-ignore
  22. .dir-locals.el
  23. .dockerignore
  24. .env
  25. .gitattributes
  26. .gitignore
  27. .gitmodules
  28. .golangci.yaml
  29. .hadolint.yaml
  30. .pre-commit-config.yaml
  31. .readthedocs.yml
  32. appveyor.yml
  33. CHANGELOG.md
  34. cmake-format.py
  35. CODE_OF_CONDUCT.md
  36. CONTRIBUTING.md
  37. docker-compose.yml
  38. header
  39. LICENSE.txt
  40. NOTICE.txt
  41. README.md
README.md

Apache Arrow

Fuzzing Status License Twitter Follow

Powering In-Memory Analytics

Apache Arrow is a development platform for in-memory analytics. It contains a set of technologies that enable big data systems to process and move data fast.

Major components of the project include:

Arrow is an Apache Software Foundation project. Learn more at arrow.apache.org.

What's in the Arrow libraries?

The reference Arrow libraries contain many distinct software components:

  • Columnar vector and table-like containers (similar to data frames) supporting flat or nested types
  • Fast, language agnostic metadata messaging layer (using Google's Flatbuffers library)
  • Reference-counted off-heap buffer memory management, for zero-copy memory sharing and handling memory-mapped files
  • IO interfaces to local and remote filesystems
  • Self-describing binary wire formats (streaming and batch/file-like) for remote procedure calls (RPC) and interprocess communication (IPC)
  • Integration tests for verifying binary compatibility between the implementations (e.g. sending data from Java to C++)
  • Conversions to and from other in-memory data structures
  • Readers and writers for various widely-used file formats (such as Parquet, CSV)

Implementation status

The official Arrow libraries in this repository are in different stages of implementing the Arrow format and related features. See our current feature matrix on git main.

How to Contribute

Please read our latest project contribution guide.

Getting involved

Even if you do not plan to contribute to Apache Arrow itself or Arrow integrations in other projects, we'd be happy to have you involved: