Google Git
Sign in
apache / arrow / 966a8040151ebe6276d14ee0c6e98b085daab887
commit966a8040151ebe6276d14ee0c6e98b085daab887[log] [tgz]
authorMatt Topol <zotthewizard@gmail.com>Mon Apr 24 20:36:06 2023 -0400
committerGitHub <noreply@github.com>Mon Apr 24 20:36:06 2023 -0400
tree1be3f7ebada2b4a24c8a620c35e972429cb3de49
parent5de56928e0fe43f02005552eee058de57ffb2682 [diff]
GH-35310: [Go] Incorrect value decimal128 from string (#35311)



### Rationale for this change
Fix edge case of rounding when parsing a decimal128 value from string with a high precision.

### What changes are included in this PR?
Adding a simple 0.5 rounding based on the signbit before we truncate the value to an integer.

### Are these changes tested?
Yes, an edge case test case was added.

### Are there any user-facing changes?
Some values that were previously incorrect will now be correct.

* Closes: #35310

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
3 files changed
tree: 1be3f7ebada2b4a24c8a620c35e972429cb3de49
  1. .github/
  2. c_glib/
  3. ci/
  4. cpp/
  5. csharp/
  6. dev/
  7. docs/
  8. format/
  9. go/
  10. java/
  11. js/
  12. matlab/
  13. python/
  14. r/
  15. ruby/
  16. swift/
  17. testing
  18. .asf.yaml
  19. .clang-format
  20. .clang-tidy
  21. .clang-tidy-ignore
  22. .dir-locals.el
  23. .dockerignore
  24. .env
  25. .gitattributes
  26. .gitignore
  27. .gitmodules
  28. .hadolint.yaml
  29. .pre-commit-config.yaml
  30. .readthedocs.yml
  31. .travis.yml
  32. appveyor.yml
  33. CHANGELOG.md
  34. cmake-format.py
  35. CODE_OF_CONDUCT.md
  36. CONTRIBUTING.md
  37. docker-compose.yml
  38. header
  39. LICENSE.txt
  40. NOTICE.txt
  41. README.md
README.md

Apache Arrow

Fuzzing Status License Twitter Follow

Powering In-Memory Analytics

Apache Arrow is a development platform for in-memory analytics. It contains a set of technologies that enable big data systems to process and move data fast.

Major components of the project include:

Arrow is an Apache Software Foundation project. Learn more at arrow.apache.org.

What's in the Arrow libraries?

The reference Arrow libraries contain many distinct software components:

  • Columnar vector and table-like containers (similar to data frames) supporting flat or nested types
  • Fast, language agnostic metadata messaging layer (using Google's Flatbuffers library)
  • Reference-counted off-heap buffer memory management, for zero-copy memory sharing and handling memory-mapped files
  • IO interfaces to local and remote filesystems
  • Self-describing binary wire formats (streaming and batch/file-like) for remote procedure calls (RPC) and interprocess communication (IPC)
  • Integration tests for verifying binary compatibility between the implementations (e.g. sending data from Java to C++)
  • Conversions to and from other in-memory data structures
  • Readers and writers for various widely-used file formats (such as Parquet, CSV)

Implementation status

The official Arrow libraries in this repository are in different stages of implementing the Arrow format and related features. See our current feature matrix on git main.

How to Contribute

Please read our latest project contribution guide.

Getting involved

Even if you do not plan to contribute to Apache Arrow itself or Arrow integrations in other projects, we'd be happy to have you involved: