tree 604d6536f1daeeaa3b1ea0791c35a254dc5fc13b
parent f55f657914afc1476f72a939143874256ebb411b
author Micah Kornfield <micahk@google.com> 1614874718 +0100
committer Antoine Pitrou <antoine@python.org> 1614874718 +0100

PARQUET-1655: [C++] Fix comparison of Decimal values in statistics

The prior logic, I don't think is ever correct for signed
comparison.  Signed comparison of bytes as far as I can
tell from the specification is only used by Decimal
encoded values.  Decimals are always encoded as big-endian
two's complement integers.

The new logic reflects this by doing sign extension when
necessary for comparisons, and only using signed byte comparison
for the very first value when appropriate.

This PR also eliminates what appears to be a some dead code.

Closes #9582 from emkornfield/parquet_stats

Lead-authored-by: Micah Kornfield <micahk@google.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>