| commit | 616305cb9005351f2e0c3cddb075fc06618ec779 | [log] [tgz] |
|---|---|---|
| author | Wes McKinney <wesm@apache.org> | Mon Jul 11 20:22:10 2016 -0700 |
| committer | Wes McKinney <wesm@apache.org> | Mon Jul 11 20:22:10 2016 -0700 |
| tree | 416b7f268724babad11c45bc91b43501bfc73298 | |
| parent | 29c6bff491a138996de06e4bdff4921381ed39d0 [diff] |
PARQUET-662: Compile ParquetException implementation and explicitly export This was causing downstream failure in ARROW-237. Now thirdparty libraries can safely throw `ParquetException` and be properly recognized on both ends. Author: Wes McKinney <wesm@apache.org> Closes #139 from wesm/PARQUET-662 and squashes the following commits: c1458d2 [Wes McKinney] Move ParquetException impl to object code, explicitly export. Add LINKAGE option to ADD_PARQUET_TEST, test throwing ParquetException via shared lib. Build shared library in gcc build.
You can install these dependencies using a package manager or using the thirdparty/ scripts in this repository. On Homebrew, you can run:
brew install snappy lz4 thrift zlib
To build the thirdparty libraries in-tree, run:
./thirdparty/download_thirdparty.sh ./thirdparty/build_thirdparty.sh source thirdparty/set_thirdparty_env.sh
The provided script setup_build_env.sh sets up a build environment for you with third party dependencies. You use it by running source setup_build_env.sh. By default, it will create a build directory build/. You can override the build directory by setting the BUILD_DIR env variable to another location.
After building the thirdparty libraries, for future development iteration you can set the dependency environment variables (detailed below) by running
source $BUILD_DIR/thirdparty/set_thirdparty_env.sh
Note, the environment variables are set automatically the first time you run setup_build_env.sh.
The unit tests depend on googletest which cannot be installed with Homebrew or normal package managers. If you wish to use system dependencies, we recommend that you build googletest in-tree by running:
./thirdparty/download_thirdparty.sh ./thirdparty/build_thirdparty.sh gtest source thirdparty/versions.sh export GTEST_HOME=`pwd`/thirdparty/$GTEST_BASEDIR
cmake .
make
The binaries will be built to ./debug which contains the libraries to link against as well as a few example executables.
Incremental builds can be done afterwords with just make.
This library uses Google's googletest unit test framework. After building with make, you can run the test suite by running
make unittest
The test suite relies on an environment variable PARQUET_TEST_DATA pointing to the data directory in the source checkout, for example:
export PARQUET_TEST_DATA=`pwd`/data
If you run source setup_build_env.sh it will set this variable automatically, but you may also wish to put it in your .bashrc or somewhere else.
See ctest --help for configuration details about ctest. On GNU/Linux systems, you can use valgrind with ctest to look for memory leaks:
valgrind --tool=memcheck --leak-check=yes ctest
Follow the directions for simple build except run cmake with the --PARQUET_BUILD_BENCHMARKS parameter set correctly:
cmake -DPARQUET_BUILD_BENCHMARKS=ON ..
and instead of make unittest run either make; ctest to run both unit tests and benchmarks or make runbenchmark to run only the benchmark tests.
Benchmark logs will be placed in the build directory under build/benchmark-logs.
parquet-cpp supports out of source builds. For example:
mkdir test-build cd test-build cmake .. make ctest -L unittest
By using out-of-source builds you can preserve your current build state in case you need to switch to another git branch.
The library consists of 3 layers that map to the 3 units in the parquet format.
The first is the encodings which correspond to data pages. The APIs at this level return single values.
The second layer is the column reader which corresponds to column chunks. The APIs at this level return a triple: definition level, repetition level and value. It also handles reading pages, compression and managing encodings.
The 3rd layer would handle reading/writing records.
The project adheres to the google coding convention: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml with two notable exceptions. We do not encourage anonymous namespaces and the line length is 90 characters.
You can run cpplint through the build system with
make lint
The project prefers the use of C++ style memory management. new/delete should be used over malloc/free. new/delete should be avoided whenever possible by using stl/boost where possible. For example, scoped_ptr instead of explicit new/delete and using std::vector instead of allocated buffers. Currently, c++11 features are not used.
For error handling, this project uses exceptions.
In general, many of the APIs at the layers are interface based for extensibility. To minimize the cost of virtual calls, the APIs should be batch-centric. For example, encoding should operate on batches of values rather than a single value.
Suppose you are building libraries with a thirdparty gcc toolchain (not a built-in system one) on Linux. To use clang for development while linking to the proper toolchain, you can do (for out of source builds):
export CMAKE_CLANG_OPTIONS=--gcc-toolchain=$TOOLCHAIN/gcc-4.9.2 export CC=$TOOLCHAIN/llvm-3.7.0/bin/clang export CXX=$TOOLCHAIN/llvm-3.7.0/bin/clang++ cmake -DCMAKE_CLANG_OPTIONS=$CMAKE_CLANG_OPTIONS \ -DCMAKE_CXX_FLAGS="-Werror" ..
To build with gcov code coverage and upload results to http://coveralls.io or http://codecov.io, here are some instructions.
First, build the project with coverage and run the test suite
cd $PARQUET_HOME mkdir coverage-build cd coverage-build cmake -DPARQUET_GENERATE_COVERAGE=1 make -j$PARALLEL ctest -L unittest
The gcov artifacts are not located in a place that works well with either coveralls or codecov, so there is a helper script you need to run
mkdir coverage_artifacts python ../build-support/collect_coverage.py CMakeFiles/parquet.dir/src/ coverage_artifacts
For codecov.io (using the provided project token -- be sure to keep this private):
cd coverage_artifacts codecov --token $PARQUET_CPP_CODECOV_TOKEN --gcov-args '\-l' --root $PARQUET_ROOT
For coveralls, install cpp_coveralls:
pip install cpp_coveralls
And the coveralls upload script:
coveralls -t $PARQUET_CPP_COVERAGE_TOKEN --gcov-options '\-l' -r $PARQUET_ROOT --exclude $PARQUET_ROOT/thirdparty --exclude $PARQUET_ROOT/build --exclude $NATIVE_TOOLCHAIN --exclude $PARQUET_ROOT/src/parquet/thrift
Note that gcov throws off artifacts from the STL, so I excluded my toolchain root stored in $NATIVE_TOOLCHAIN to avoid a cluttered coverage report.